Skip to content

Conversation

@Max-le
Copy link
Contributor

@Max-le Max-le commented Jun 8, 2022

Hi frog23,

Hereby I propose to use the css framework Skeleton for a slight improvement of design.

So I added skeleton.css, linked it to index.html and review.html, and removed the Helvetica font on tsm.css to apply Skeleton's font.
Finally I changed the a tag's color to red.

See the two screenshots below for an overview.

Screenshot 2022-06-08 at 19 04 40

Screenshot 2022-06-08 at 19 04 35

.

Let me know if you like it !

@Max-le Max-le marked this pull request as ready for review June 8, 2022 17:16
@Plushb9rry
Copy link
Contributor

That looks awesome, i was also trying to improve the page few days ago, but I didn't complete it well.

image

@Plushb9rry
Copy link
Contributor

So I added skeleton.css, linked it to index.html and review.html, and removed the Helvetica font on tsm.css to apply Skeleton's font. Finally I changed the a tag's color to red.

These fonts look a lot familiar to 'Railway' by google

@Max-le
Copy link
Contributor Author

Max-le commented Jun 9, 2022

Thanks, your idea looks cool as well ( and yes, you recognized the font correctly )
:)

@frog23 frog23 merged commit cfd2d66 into frog23:master Jul 10, 2022
@frog23
Copy link
Owner

frog23 commented Jul 10, 2022

Hey Max-le,
thank you for your PR. The site looks a lot better now. Sorry, that it took me so long to respond. It has been a busy couple of weeks and I didn't have time to properly review the PR.
Thanks again and sorry for the wait.
Cheers, Frog23

@Plushb9rry
Copy link
Contributor

also, which of these look good?

image
image

@Max-le
Copy link
Contributor Author

Max-le commented Jul 10, 2022

I prefer the first one, with his face ! 🙂

@frog23
Copy link
Owner

frog23 commented Jul 10, 2022

I added my thoughts on the matter here: #50 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants