fix: skip tsconfig excludes for direct changes

[nirsky]

Summary

• A directly changed file always belongs to its project — tsconfig excludes define what TypeScript compiles, not what belongs to a project
• Previously, changing a .spec.ts or .stories.tsx file produced "no affected projects" because tsconfig.app.json excludes them
• Added get_owning_packages_by_path — same path-prefix lookup as get_package_names_by_path but without tsconfig exclude filtering
• Used for all direct-change ownership lookups in Steps 6a (source files) and 6b (assets)
• The existing filtered method is preserved for reference traversal where cascade through excluded files may be undesirable

Before

change di.spec.ts →
  File "...di.spec.ts" excluded by tsconfig for project 'browser-desktop-background'
  Affected projects: []

After

change di.spec.ts →
  File "...di.spec.ts" belongs to package 'browser-desktop-background'
  Affected projects: ["browser-desktop-background", "browser-desktop-extension"]

Test plan

• New unit test test_get_owning_packages_skips_tsconfig_excludes — verifies both methods side-by-side
• 192 unit tests pass, 9 integration tests pass
• End-to-end on 1685-project monorepo: di.spec.ts change correctly marks browser-desktop-background affected

🤖 Generated with Claude Code

Summary by CodeRabbit

• Bug Fixes

  • Improved detection of which projects are affected by file changes so that files excluded by build configuration (e.g., excluded test/config patterns) still mark their owning project as affected.

• Tests

  • Added integration tests validating that direct edits to excluded files correctly mark the owning project as affected.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: fd7fc452-8fb7-4913-b45b-fd7ea180c749

📥 Commits

Reviewing files that changed from the base of the PR and between 48939f6 and 7c5e1c7.

📒 Files selected for processing (2)

• src/utils.rs
• tests/integration_test.rs

---

📝 Walkthrough

Walkthrough

Swaps the project-lookup used when mapping changed files from the tsconfig-filtered get_package_names_by_path to a new unfiltered get_owning_packages_by_path, and adds tests verifying ownership differs when tsconfig excludes would otherwise hide files.

Changes

Cohort / File(s)	Summary
Core ownership swap src/core.rs	Replaces calls to get_package_names_by_path with get_owning_packages_by_path for direct file ownership mapping; updates inline comments to note excludes are bypassed (+7/-5).
Package resolution & tests src/utils.rs, tests/integration_test.rs	Extracts shared resolver into resolve_packages(..., skip_excludes), adds pub fn get_owning_packages_by_path(&self, file_path: &Path) -> Vec<String>, keeps get_package_names_by_path filtered, and adds integration/unit tests validating filtered vs unfiltered behavior (+129/-21; +75/-0).

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

• fix: report all projects when multiple share the same sourceRoot #39: Related changes to package lookup behavior and multi-match handling; likely touches same ownership resolution area.
• fix: respect tsconfig exclude patterns in project ownership checks #46: Introduced tsconfig-based filtering to get_package_names_by_path; this PR adds the unfiltered counterpart and switches usage.
• fix: detect affected projects for files inside root but outside sourceRoot #61: Adjusts root-fallback and ownership lookup logic; overlaps with how excludes and root entries are handled.

Suggested reviewers

• EladBezalel

Poem

🐰 I nibble through code paths, soft and spry,
Unhiding owners where hidden files lie.
A hop, a sniff, a mapping true—
Projects found where excludes once grew. ✨

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title 'fix: skip tsconfig excludes for direct changes' directly and concisely describes the main change: implementing logic to skip tsconfig excludes when determining ownership for directly modified files.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch fix/skip-excludes-for-direct-changes

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[cubic-dev-ai]

No issues found across 2 files

[github-actions]

📦 Preview Release Available

A preview release has been published for commit 7c5e1c7.

Installation

npm install https://github.com/frontops-dev/domino/releases/download/pr-66-7c5e1c7/front-ops-domino-1.2.5.tgz

Running the preview

npx https://github.com/frontops-dev/domino/releases/download/pr-66-7c5e1c7/front-ops-domino-1.2.5.tgz affected

Details

• Release: pr-66-7c5e1c7
• Direct URL: https://github.com/frontops-dev/domino/releases/download/pr-66-7c5e1c7/front-ops-domino-1.2.5.tgz

[EladBezalel]

Clean separation of ownership vs reference traversal — exactly the right approach. Two suggestions, neither blocking.

[EladBezalel]

All review feedback addressed — helper extracted, fast-path tested, integration test added. LGTM.