Allow Windows CRLF in ScriptLoader CLI checks#143
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughCI workflows in Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Suite Timing
Measured on ubuntu-latest x64. |
Benchmark Results263 benchmarks Interpreted: 🟢 81 improved · 🔴 3 regressed · 179 unchanged · avg +4.6% arraybuffer.js — Interp: 🟢 9, 5 unch. · avg +7.8% · Bytecode: 🔴 12, 2 unch. · avg -11.8%
arrays.js — Interp: 🟢 10, 9 unch. · avg +7.1% · Bytecode: 🔴 19 · avg -15.4%
async-await.js — Interp: 🟢 3, 3 unch. · avg +6.9% · Bytecode: 🔴 6 · avg -14.2%
classes.js — Interp: 🟢 29, 2 unch. · avg +10.4% · Bytecode: 🔴 31 · avg -20.5%
closures.js — Interp: 🟢 3, 8 unch. · avg +6.3% · Bytecode: 🔴 11 · avg -14.0%
collections.js — Interp: 🟢 4, 8 unch. · avg +4.4% · Bytecode: 🔴 4, 8 unch. · avg -6.5%
destructuring.js — Interp: 🟢 8, 14 unch. · avg +5.7% · Bytecode: 🔴 21, 1 unch. · avg -13.0%
fibonacci.js — Interp: 8 unch. · avg +2.6% · Bytecode: 🔴 7, 1 unch. · avg -13.4%
for-of.js — Interp: 7 unch. · avg +1.7% · Bytecode: 🔴 7 · avg -11.4%
helpers/bench-module.js — Interp: 0 · Bytecode: 0
iterators.js — Interp: 20 unch. · avg +1.2% · Bytecode: 🔴 20 · avg -15.8%
json.js — Interp: 🟢 10, 10 unch. · avg +6.0% · Bytecode: 🔴 19, 1 unch. · avg -13.1%
jsx.jsx — Interp: 🟢 2, 19 unch. · avg +4.5% · Bytecode: 🔴 18, 3 unch. · avg -12.5%
modules.js — Interp: 9 unch. · avg +0.1% · Bytecode: 🔴 9 · avg -15.6%
numbers.js — Interp: 11 unch. · avg +2.6% · Bytecode: 🔴 11 · avg -13.4%
objects.js — Interp: 7 unch. · avg +1.4% · Bytecode: 🔴 6, 1 unch. · avg -13.0%
promises.js — Interp: 🔴 2, 10 unch. · avg -2.1% · Bytecode: 🔴 11, 1 unch. · avg -12.7%
strings.js — Interp: 🟢 1, 10 unch. · avg +3.3% · Bytecode: 🔴 10, 1 unch. · avg -11.7%
typed-arrays.js — Interp: 🟢 2, 🔴 1, 19 unch. · avg +1.8% · Bytecode: 🔴 21, 1 unch. · avg -15.0%
Measured on ubuntu-latest x64. Changes within ±7% are considered insignificant. |
Summary
Verification
Summary by CodeRabbit