Expand JSON.stringify error coverage#145
Conversation
|
Warning Rate limit exceeded
Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 4 minutes and 15 seconds. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (4)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Benchmark Results263 benchmarks Interpreted: 🔴 19 regressed · 244 unchanged · avg -2.5% arraybuffer.js — Interp: 14 unch. · avg -0.0% · Bytecode: 🔴 8, 6 unch. · avg -8.2%
arrays.js — Interp: 19 unch. · avg +0.2% · Bytecode: 🔴 18, 1 unch. · avg -10.1%
async-await.js — Interp: 6 unch. · avg +2.0% · Bytecode: 🔴 5, 1 unch. · avg -8.5%
classes.js — Interp: 31 unch. · avg -0.5% · Bytecode: 🔴 20, 11 unch. · avg -7.7%
closures.js — Interp: 11 unch. · avg -0.1% · Bytecode: 🔴 4, 7 unch. · avg -6.0%
collections.js — Interp: 12 unch. · avg +0.3% · Bytecode: 🔴 3, 9 unch. · avg -3.3%
destructuring.js — Interp: 22 unch. · avg -1.7% · Bytecode: 🔴 13, 9 unch. · avg -8.4%
fibonacci.js — Interp: 8 unch. · avg -3.4% · Bytecode: 🔴 7, 1 unch. · avg -10.6%
for-of.js — Interp: 7 unch. · avg -5.4% · Bytecode: 🔴 2, 5 unch. · avg -4.5%
helpers/bench-module.js — Interp: 0 · Bytecode: 0
iterators.js — Interp: 🔴 5, 15 unch. · avg -5.7% · Bytecode: 🔴 19, 1 unch. · avg -11.4%
json.js — Interp: 🔴 11, 9 unch. · avg -8.2% · Bytecode: 🔴 17, 3 unch. · avg -11.8%
jsx.jsx — Interp: 21 unch. · avg -1.1% · Bytecode: 🔴 1, 20 unch. · avg -3.1%
modules.js — Interp: 9 unch. · avg -3.1% · Bytecode: 🔴 7, 2 unch. · avg -9.2%
numbers.js — Interp: 🔴 1, 10 unch. · avg -3.2% · Bytecode: 🔴 7, 4 unch. · avg -9.9%
objects.js — Interp: 🔴 1, 6 unch. · avg -4.6% · Bytecode: 7 unch. · avg -2.9%
promises.js — Interp: 12 unch. · avg -3.2% · Bytecode: 12 unch. · avg -4.2%
strings.js — Interp: 11 unch. · avg -4.1% · Bytecode: 🟢 1, 🔴 4, 6 unch. · avg -3.6%
typed-arrays.js — Interp: 🔴 1, 21 unch. · avg -3.7% · Bytecode: 🔴 14, 8 unch. · avg -9.0%
Measured on ubuntu-latest x64. Changes within ±7% are considered insignificant. |
Suite Timing
Measured on ubuntu-latest x64. |
Summary
JSON.stringifycoverage for circular references,toJSON, thrown errors, invalid replacers/space, symbols, functions, deep nesting, and sparse arraystoJSON()handlingJSON.stringifyspecial cases indocs/built-ins.mdTesting
./build.pas clean loader./build.pas testrunner./build/TestRunner tests/built-ins/JSON/stringify.js --no-progress./build/TestRunner tests --no-progressCloses #122.