Harden OrderedStringMap tombstone compaction#148
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
📝 WalkthroughWalkthroughThis change implements deleted-bucket tracking in Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Suite Timing
Measured on ubuntu-latest x64. |
Benchmark Results263 benchmarks Interpreted: 🟢 13 improved · 🔴 146 regressed · 104 unchanged · avg -1.7% arraybuffer.js — Interp: 🔴 12, 2 unch. · avg -3.5% · Bytecode: 🟢 1, 🔴 11, 2 unch. · avg -6.4%
arrays.js — Interp: 🟢 1, 🔴 18 · avg -3.2% · Bytecode: 🔴 19 · avg -10.4%
async-await.js — Interp: 🔴 2, 4 unch. · avg -0.8% · Bytecode: 🔴 6 · avg -7.9%
classes.js — Interp: 🟢 2, 🔴 5, 24 unch. · avg -0.2% · Bytecode: 🟢 6, 🔴 10, 15 unch. · avg -0.2%
closures.js — Interp: 🔴 10, 1 unch. · avg -2.2% · Bytecode: 🔴 5, 6 unch. · avg -2.4%
collections.js — Interp: 🟢 2, 🔴 7, 3 unch. · avg -1.8% · Bytecode: 🟢 4, 🔴 7, 1 unch. · avg -5.4%
destructuring.js — Interp: 🔴 16, 6 unch. · avg -2.5% · Bytecode: 🟢 3, 🔴 13, 6 unch. · avg -4.5%
fibonacci.js — Interp: 🔴 7, 1 unch. · avg -4.0% · Bytecode: 🔴 8 · avg -5.8%
for-of.js — Interp: 🔴 3, 4 unch. · avg -1.7% · Bytecode: 🟢 1, 🔴 5, 1 unch. · avg -3.2%
helpers/bench-module.js — Interp: 0 · Bytecode: 0
iterators.js — Interp: 🔴 17, 3 unch. · avg -3.0% · Bytecode: 🟢 1, 🔴 17, 2 unch. · avg -6.7%
json.js — Interp: 🟢 3, 🔴 3, 14 unch. · avg -0.1% · Bytecode: 🔴 20 · avg -8.3%
jsx.jsx — Interp: 🟢 1, 🔴 14, 6 unch. · avg -1.5% · Bytecode: 🟢 9, 12 unch. · avg +1.3%
modules.js — Interp: 🔴 7, 2 unch. · avg -2.4% · Bytecode: 🟢 4, 🔴 2, 3 unch. · avg -0.1%
numbers.js — Interp: 🔴 5, 6 unch. · avg -2.4% · Bytecode: 🟢 1, 🔴 8, 2 unch. · avg -5.6%
objects.js — Interp: 🔴 4, 3 unch. · avg -2.4% · Bytecode: 🟢 1, 🔴 1, 5 unch. · avg +0.6%
promises.js — Interp: 🟢 1, 11 unch. · avg +0.5% · Bytecode: 🔴 4, 8 unch. · avg -1.6%
strings.js — Interp: 🔴 6, 5 unch. · avg -1.6% · Bytecode: 🔴 11 · avg -6.3%
typed-arrays.js — Interp: 🟢 3, 🔴 10, 9 unch. · avg -1.0% · Bytecode: 🟢 11, 🔴 4, 7 unch. · avg +1.7%
Measured on ubuntu-latest x64. Benchmark ranges compare cached main-branch min/max ops/sec with the PR run; overlapping ranges are treated as unchanged noise. Percentage deltas are secondary context. |
Summary
TOrderedStringMapand reset the counter on rebuild pathsTesting
Closes #103
Summary by CodeRabbit
New Features
Tests
Documentation