Make import.meta tests account for Windows drive letters#274
Merged
Conversation
- Detect the current file URL drive letter in the module test - Expect `import.meta.resolve()` to include the drive prefix on Windows
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThis change modifies a test file to add Windows-specific handling for Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes 🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Comment |
Contributor
Benchmark Results364 benchmarks Interpreted: 🟢 267 improved · 🔴 19 regressed · 78 unchanged · avg +2.8% arraybuffer.js — Interp: 🟢 4, 🔴 2, 8 unch. · avg +0.7% · Bytecode: 🟢 13, 1 unch. · avg +9.9%
arrays.js — Interp: 🟢 14, 🔴 2, 3 unch. · avg +2.3% · Bytecode: 🟢 19 · avg +10.9%
async-await.js — Interp: 🟢 5, 1 unch. · avg +1.6% · Bytecode: 🟢 6 · avg +8.2%
base64.js — Interp: 🟢 3, 🔴 1, 6 unch. · avg +0.4% · Bytecode: 🟢 10 · avg +10.4%
classes.js — Interp: 🟢 28, 3 unch. · avg +2.7% · Bytecode: 🟢 19, 🔴 1, 11 unch. · avg +7.2%
closures.js — Interp: 🟢 8, 3 unch. · avg +2.6% · Bytecode: 🟢 10, 1 unch. · avg +7.6%
collections.js — Interp: 🟢 8, 4 unch. · avg +2.4% · Bytecode: 🟢 10, 🔴 1, 1 unch. · avg +4.7%
destructuring.js — Interp: 🟢 22 · avg +4.7% · Bytecode: 🟢 22 · avg +8.9%
fibonacci.js — Interp: 🟢 7, 1 unch. · avg +3.2% · Bytecode: 🟢 8 · avg +13.2%
float16array.js — Interp: 🟢 27, 🔴 1, 4 unch. · avg +4.6% · Bytecode: 🟢 32 · avg +16.8%
for-of.js — Interp: 🟢 7 · avg +7.0% · Bytecode: 🟢 7 · avg +5.5%
helpers/bench-module.js — Interp: 0 · Bytecode: 0
iterators.js — Interp: 🟢 35, 7 unch. · avg +4.1% · Bytecode: 🟢 36, 6 unch. · avg +7.4%
json.js — Interp: 🟢 13, 7 unch. · avg +1.5% · Bytecode: 🟢 20 · avg +9.7%
jsx.jsx — Interp: 🟢 3, 🔴 4, 14 unch. · avg +0.1% · Bytecode: 🟢 20, 1 unch. · avg +4.8%
modules.js — Interp: 🟢 5, 🔴 1, 3 unch. · avg +1.0% · Bytecode: 🟢 8, 1 unch. · avg +8.0%
numbers.js — Interp: 🟢 8, 🔴 1, 2 unch. · avg +2.1% · Bytecode: 🟢 10, 1 unch. · avg +12.1%
objects.js — Interp: 🟢 7 · avg +4.1% · Bytecode: 🟢 6, 1 unch. · avg +5.3%
promises.js — Interp: 🟢 10, 2 unch. · avg +2.8% · Bytecode: 🟢 12 · avg +7.9%
regexp.js — Interp: 🟢 11 · avg +2.7% · Bytecode: 🟢 11 · avg +6.2%
strings.js — Interp: 🟢 18, 1 unch. · avg +3.8% · Bytecode: 🟢 18, 1 unch. · avg +9.2%
typed-arrays.js — Interp: 🟢 16, 🔴 1, 5 unch. · avg +3.5% · Bytecode: 🟢 19, 🔴 1, 2 unch. · avg +9.7%
uint8array-encoding.js — Interp: 🟢 8, 🔴 6, 4 unch. · avg +1.2% · Bytecode: 🟢 13, 🔴 5 · avg +6.0%
Measured on ubuntu-latest x64. Benchmark ranges compare cached main-branch min/max ops/sec with the PR run; overlapping ranges are treated as unchanged noise. Percentage deltas are secondary context. |
Contributor
Suite Timing
Measured on ubuntu-latest x64. |
frostney
added a commit
that referenced
this pull request
Apr 11, 2026
Incorporates 5 commits from main: - TextEncoder and TextDecoder built-ins (#272) - Make import.meta tests account for Windows drive letters (#274) - Fixes tagged template object identity (#275) - Add Goccia.build platform metadata (#276) - Add ToObject coercion for primitives across all Object.* static methods (#271) Conflict resolution in 3 files (all "both sides added" — keep both): Goccia.Engine.pas / Goccia.Runtime.Bootstrap.pas: - Added ggTextEncoder and ggTextDecoder to TGocciaGlobalBuiltin enum - Added both to DefaultGlobals alongside ggURL - Added FBuiltinTextEncoder/FBuiltinTextDecoder fields, Free calls, registration blocks, Expose* helpers, and constructor TypeDef blocks alongside the existing URL equivalents Goccia.Values.ClassValue.pas: - Added TGocciaTextEncoderClassValue and TGocciaTextDecoderClassValue declarations, impl uses, and CreateNativeInstance implementations alongside the existing URL equivalents Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
import.meta.resolve()to include the drive prefix on Windows