Handle EOF before REPL prompt on Windows#385
Conversation
- Return `lrExit` immediately when stdin is already at EOF on non-UNIX builds - Avoid writing the prompt or blocking on `ReadLn` after input is closed
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughA bug fix for Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Suggested labels
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Comment |
Suite Timing
Measured on ubuntu-latest x64. |
Benchmark Results386 benchmarks Interpreted: 🟢 10 improved · 🔴 343 regressed · 33 unchanged · avg -8.6% arraybuffer.js — Interp: 🔴 9, 5 unch. · avg -7.6% · Bytecode: 🔴 5, 9 unch. · avg -1.7%
arrays.js — Interp: 🔴 18, 1 unch. · avg -11.1% · Bytecode: 🔴 8, 11 unch. · avg -1.3%
async-await.js — Interp: 🔴 5, 1 unch. · avg -10.6% · Bytecode: 🟢 1, 5 unch. · avg +0.4%
base64.js — Interp: 🔴 10 · avg -9.6% · Bytecode: 🟢 2, 🔴 1, 7 unch. · avg +1.1%
classes.js — Interp: 🔴 30, 1 unch. · avg -9.0% · Bytecode: 🟢 6, 🔴 1, 24 unch. · avg +0.8%
closures.js — Interp: 🔴 10, 1 unch. · avg -9.5% · Bytecode: 🟢 1, 🔴 1, 9 unch. · avg -0.1%
collections.js — Interp: 🔴 12 · avg -13.5% · Bytecode: 🟢 1, 🔴 4, 7 unch. · avg -1.4%
csv.js — Interp: 🔴 13 · avg -11.7% · Bytecode: 🔴 2, 11 unch. · avg -0.0%
destructuring.js — Interp: 🔴 22 · avg -8.9% · Bytecode: 🟢 2, 🔴 2, 18 unch. · avg +0.3%
fibonacci.js — Interp: 🔴 8 · avg -10.3% · Bytecode: 🟢 1, 7 unch. · avg -0.2%
float16array.js — Interp: 🟢 4, 🔴 24, 4 unch. · avg -4.7% · Bytecode: 🟢 18, 🔴 1, 13 unch. · avg +3.6%
for-of.js — Interp: 🔴 7 · avg -6.9% · Bytecode: 🟢 2, 🔴 1, 4 unch. · avg +0.6%
helpers/bench-module.js — Interp: 0 · Bytecode: 0
iterators.js — Interp: 🔴 41, 1 unch. · avg -8.3% · Bytecode: 🟢 4, 🔴 3, 35 unch. · avg -0.4%
json.js — Interp: 🔴 18, 2 unch. · avg -9.2% · Bytecode: 🟢 6, 🔴 4, 10 unch. · avg +0.9%
jsx.jsx — Interp: 🔴 20, 1 unch. · avg -9.1% · Bytecode: 🟢 1, 🔴 2, 18 unch. · avg +0.2%
modules.js — Interp: 🔴 9 · avg -8.9% · Bytecode: 🟢 2, 🔴 2, 5 unch. · avg +0.6%
numbers.js — Interp: 🔴 11 · avg -12.7% · Bytecode: 🟢 2, 🔴 2, 7 unch. · avg -0.3%
objects.js — Interp: 🔴 4, 3 unch. · avg -3.1% · Bytecode: 🟢 3, 🔴 1, 3 unch. · avg -0.1%
promises.js — Interp: 🔴 11, 1 unch. · avg -7.6% · Bytecode: 🟢 1, 11 unch. · avg +0.9%
regexp.js — Interp: 🔴 11 · avg -8.1% · Bytecode: 🟢 5, 6 unch. · avg +2.2%
strings.js — Interp: 🟢 1, 🔴 15, 3 unch. · avg -4.7% · Bytecode: 🟢 2, 🔴 5, 12 unch. · avg -9.7%
tsv.js — Interp: 🔴 7, 2 unch. · avg -8.3% · Bytecode: 🟢 2, 7 unch. · avg +1.9%
typed-arrays.js — Interp: 🟢 3, 🔴 17, 2 unch. · avg -4.9% · Bytecode: 🟢 5, 🔴 7, 10 unch. · avg +0.2%
uint8array-encoding.js — Interp: 🟢 2, 🔴 11, 5 unch. · avg -14.4% · Bytecode: 🟢 5, 🔴 6, 7 unch. · avg -9.4%
Measured on ubuntu-latest x64. Benchmark ranges compare cached main-branch min/max ops/sec with the PR run; overlapping ranges are treated as unchanged noise. Percentage deltas are secondary context. |
Summary
lrExitimmediately whenInputis already at EOF, instead of attempting to read a line.Testing
ReadLn.