Fix ZonedDateTime DST-aware diff rounding#435
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (4)
📝 WalkthroughWalkthroughThis PR implements DST-aware rounding for Changes
Estimated code review effort🎯 4 (Complex) | ⏱️ ~50 minutes Possibly related PRs
Suggested labels
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Comment |
Benchmark Results386 benchmarks Interpreted: 🟢 33 improved · 🔴 66 regressed · 287 unchanged · avg -1.7% arraybuffer.js — Interp: 14 unch. · avg -1.7% · Bytecode: 🟢 1, 🔴 10, 3 unch. · avg -3.9%
arrays.js — Interp: 🟢 1, 🔴 1, 17 unch. · avg -1.2% · Bytecode: 🔴 14, 5 unch. · avg -3.8%
async-await.js — Interp: 🔴 2, 4 unch. · avg -2.6% · Bytecode: 🟢 1, 🔴 3, 2 unch. · avg -0.9%
base64.js — Interp: 🔴 3, 7 unch. · avg -1.2% · Bytecode: 🔴 8, 2 unch. · avg -3.6%
classes.js — Interp: 🟢 1, 🔴 2, 28 unch. · avg -0.0% · Bytecode: 🟢 3, 🔴 9, 19 unch. · avg -1.6%
closures.js — Interp: 🔴 2, 9 unch. · avg -1.6% · Bytecode: 🔴 7, 4 unch. · avg -4.6%
collections.js — Interp: 🔴 1, 11 unch. · avg -1.0% · Bytecode: 🟢 5, 🔴 2, 5 unch. · avg +1.3%
csv.js — Interp: 🟢 1, 🔴 1, 11 unch. · avg -0.4% · Bytecode: 🔴 9, 4 unch. · avg -8.3%
destructuring.js — Interp: 🔴 3, 19 unch. · avg -0.7% · Bytecode: 🟢 1, 🔴 11, 10 unch. · avg -3.3%
fibonacci.js — Interp: 🔴 2, 6 unch. · avg -1.2% · Bytecode: 🔴 4, 4 unch. · avg -3.4%
float16array.js — Interp: 🟢 1, 🔴 4, 27 unch. · avg -1.2% · Bytecode: 🟢 15, 🔴 8, 9 unch. · avg +18.5%
for-of.js — Interp: 🔴 3, 4 unch. · avg -2.9% · Bytecode: 🟢 1, 🔴 1, 5 unch. · avg -0.2%
helpers/bench-module.js — Interp: 0 · Bytecode: 0
iterators.js — Interp: 🟢 1, 🔴 2, 39 unch. · avg -0.6% · Bytecode: 🔴 37, 5 unch. · avg -7.2%
json.js — Interp: 🟢 2, 🔴 1, 17 unch. · avg +0.1% · Bytecode: 🟢 3, 🔴 11, 6 unch. · avg -2.4%
jsx.jsx — Interp: 🟢 1, 🔴 8, 12 unch. · avg -1.1% · Bytecode: 🔴 18, 3 unch. · avg -7.4%
modules.js — Interp: 9 unch. · avg +0.8% · Bytecode: 🔴 9 · avg -11.2%
numbers.js — Interp: 🔴 2, 9 unch. · avg -1.4% · Bytecode: 🟢 1, 🔴 10 · avg -7.3%
objects.js — Interp: 7 unch. · avg -0.6% · Bytecode: 🔴 4, 3 unch. · avg -3.7%
promises.js — Interp: 🔴 4, 8 unch. · avg -2.1% · Bytecode: 🟢 1, 🔴 5, 6 unch. · avg -2.0%
regexp.js — Interp: 🟢 3, 🔴 1, 7 unch. · avg +1.7% · Bytecode: 🔴 8, 3 unch. · avg -4.2%
strings.js — Interp: 🟢 1, 🔴 7, 11 unch. · avg -2.6% · Bytecode: 🔴 15, 4 unch. · avg -5.1%
tsv.js — Interp: 🟢 2, 🔴 4, 3 unch. · avg -3.2% · Bytecode: 🔴 9 · avg -11.0%
typed-arrays.js — Interp: 🟢 16, 🔴 2, 4 unch. · avg +2.2% · Bytecode: 🟢 21, 1 unch. · avg +11.8%
uint8array-encoding.js — Interp: 🟢 3, 🔴 11, 4 unch. · avg -19.7% · Bytecode: 🟢 9, 🔴 7, 2 unch. · avg +2.8%
Measured on ubuntu-latest x64. Benchmark ranges compare cached main-branch min/max ops/sec with the PR run; overlapping ranges are treated as unchanged noise. Percentage deltas are secondary context. |
Suite Timing
Measured on ubuntu-latest x64. |
Summary
Temporal.ZonedDateTime.prototype.until/sincerounding so date-based buckets use timezone-aware local boundary instants instead of fixed 24-hour days.untilandsince, covering day and hour rounding.Fixes #426