Declare Content Signals in robots.txt#449
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
✅ Files skipped from review due to trivial changes (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughRobots.txt generation moved from a Next.js metadata export to an explicit Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Review rate limit: 0/5 reviews remaining, refill in 52 minutes and 4 seconds. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@website/src/__tests__/robots.test.ts`:
- Around line 12-15: Add an explicit status assertion to the test by asserting
response.status is 200; locate the test in website/src/__tests__/robots.test.ts
where the test inspects response.headers and response.text (the variable is
response) and insert expect(response.status).toBe(200) before or alongside the
existing header/body assertions to lock in successful response semantics.
In `@website/src/app/robots.txt/route.ts`:
- Around line 3-8: getSiteUrl currently returns NEXT_PUBLIC_SITE_URL without
validating it, which can produce malformed Sitemap directives if the env is
blank/whitespace or missing scheme; update getSiteUrl to defensively parse and
normalize the value (trim input, attempt to construct a URL inside a try/catch
like layout.tsx does, fallback to DEFAULT_SITE_URL on failure), then strip
trailing slashes before returning so Sitemap lines are always valid; reference
the getSiteUrl function and mirror the validation/URL-construction and fallback
logic used in website/src/app/layout.tsx.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: b3c74de5-22e5-4ddd-a81e-c1f2c734b370
📒 Files selected for processing (3)
website/src/__tests__/robots.test.tswebsite/src/app/robots.tswebsite/src/app/robots.txt/route.ts
💤 Files with no reviewable changes (1)
- website/src/app/robots.ts
Contributor
Benchmark Results407 benchmarks Interpreted: 🟢 21 improved · 🔴 136 regressed · 250 unchanged · avg -1.1% arraybuffer.js — Interp: 🔴 1, 13 unch. · avg -1.7% · Bytecode: 🔴 14 · avg -29.1%
arrays.js — Interp: 🔴 9, 10 unch. · avg -2.1% · Bytecode: 🔴 19 · avg -30.8%
async-await.js — Interp: 6 unch. · avg -1.3% · Bytecode: 🔴 6 · avg -29.1%
async-generators.js — Interp: 🔴 1, 1 unch. · avg -7.0% · Bytecode: 🔴 2 · avg -31.9%
base64.js — Interp: 🟢 1, 🔴 1, 8 unch. · avg -0.5% · Bytecode: 🔴 10 · avg -31.1%
classes.js — Interp: 🔴 14, 17 unch. · avg -2.9% · Bytecode: 🔴 31 · avg -22.3%
closures.js — Interp: 🔴 4, 7 unch. · avg -2.9% · Bytecode: 🔴 11 · avg -27.4%
collections.js — Interp: 🔴 3, 9 unch. · avg -1.2% · Bytecode: 🔴 12 · avg -29.0%
csv.js — Interp: 13 unch. · avg +0.3% · Bytecode: 🔴 13 · avg -29.7%
destructuring.js — Interp: 🔴 13, 9 unch. · avg -3.9% · Bytecode: 🔴 22 · avg -27.5%
fibonacci.js — Interp: 🔴 3, 5 unch. · avg -2.5% · Bytecode: 🔴 8 · avg -30.3%
float16array.js — Interp: 🟢 4, 🔴 9, 19 unch. · avg -0.6% · Bytecode: 🔴 32 · avg -25.2%
for-of.js — Interp: 🔴 4, 3 unch. · avg -2.8% · Bytecode: 🔴 7 · avg -28.0%
generators.js — Interp: 🔴 2, 2 unch. · avg -2.8% · Bytecode: 🔴 4 · avg -27.0%
iterators.js — Interp: 🟢 4, 🔴 12, 26 unch. · avg -1.0% · Bytecode: 🔴 42 · avg -25.9%
json.js — Interp: 🟢 2, 🔴 5, 13 unch. · avg -1.7% · Bytecode: 🔴 20 · avg -28.4%
jsx.jsx — Interp: 🔴 6, 15 unch. · avg -2.7% · Bytecode: 🔴 21 · avg -26.6%
modules.js — Interp: 🔴 3, 6 unch. · avg -3.2% · Bytecode: 🔴 9 · avg -31.0%
numbers.js — Interp: 🔴 3, 8 unch. · avg -1.5% · Bytecode: 🔴 11 · avg -28.9%
objects.js — Interp: 🔴 2, 5 unch. · avg -2.8% · Bytecode: 🔴 7 · avg -29.6%
promises.js — Interp: 🔴 6, 6 unch. · avg -2.5% · Bytecode: 🔴 12 · avg -25.0%
regexp.js — Interp: 11 unch. · avg -0.2% · Bytecode: 🔴 11 · avg -29.1%
strings.js — Interp: 🔴 13, 6 unch. · avg -3.5% · Bytecode: 🔴 19 · avg -29.4%
tsv.js — Interp: 🔴 2, 7 unch. · avg -3.0% · Bytecode: 🔴 9 · avg -27.2%
typed-arrays.js — Interp: 🟢 7, 🔴 4, 11 unch. · avg +19.9% · Bytecode: 🔴 22 · avg -34.4%
uint8array-encoding.js — Interp: 🔴 7, 11 unch. · avg -6.3% · Bytecode: 🟢 7, 🔴 9, 2 unch. · avg -5.6%
weak-collections.js — Interp: 🟢 3, 🔴 9, 3 unch. · avg -6.1% · Bytecode: 🔴 15 · avg -36.7%
Measured on ubuntu-latest x64. Benchmark ranges compare cached main-branch min/max ops/sec with the PR run; overlapping ranges are treated as unchanged noise. Percentage deltas are secondary context. |
Contributor
Suite Timing
Measured on ubuntu-latest x64. |
Owner
Author
|
@coderabbitai review |
Contributor
✅ Actions performedReview triggered.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification