Fix changelog website grouping#459
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (4)
✅ Files skipped from review due to trivial changes (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughReorganizes the 0.7.0 changelog into a dedicated "🌐 Website" subsection, updates git-cliff configuration to detect and label commits touching Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested labels
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Review rate limit: 1/5 review remaining, refill in 47 minutes and 12 seconds. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
🧹 Nitpick comments (1)
scripts/check-doc-length.ts (1)
95-120: Consider reporting checked vs exempt counts explicitly.The summary currently prints discovered files, not evaluated files. With exemptions, this can be slightly misleading in CI logs.
♻️ Suggested tweak
const main = (): void => { const files = findMarkdownFiles(ROOT); let failures = 0; + let checkedCount = 0; + let skippedCount = 0; const results: { file: string; lines: number; limit: number }[] = []; for (const file of files) { const rel = relative(ROOT, file).split("\\").join("/"); if (EXEMPT_FILES.has(rel)) { + skippedCount++; if (VERBOSE) { console.log(` SKIP ${rel}: exempt from doc length limit`); } continue; } + checkedCount++; const content = readFileSync(file, "utf-8"); @@ - console.log(`\nChecked ${files.length} files, default limit ${DEFAULT_LIMIT} lines.`); + console.log(`\nChecked ${checkedCount} files (${skippedCount} exempt), default limit ${DEFAULT_LIMIT} lines.`);🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@scripts/check-doc-length.ts` around lines 95 - 120, Update the final reporting to show how many files were evaluated versus exempted: count exempted files when you skip (EXEMPT_FILES check) and compute evaluatedCount = files.length - exemptCount (or track evaluated when you increment failures/results), then replace the current summary console.log with one that prints total discovered files, exempt count, evaluated/checked count, and the default limit (use the existing variables files.length, EXEMPT_FILES logic, failures/results where helpful) so CI logs clearly show checked vs exempt counts.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@scripts/check-doc-length.ts`:
- Around line 95-120: Update the final reporting to show how many files were
evaluated versus exempted: count exempted files when you skip (EXEMPT_FILES
check) and compute evaluatedCount = files.length - exemptCount (or track
evaluated when you increment failures/results), then replace the current summary
console.log with one that prints total discovered files, exempt count,
evaluated/checked count, and the default limit (use the existing variables
files.length, EXEMPT_FILES logic, failures/results where helpful) so CI logs
clearly show checked vs exempt counts.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 96bd0dcc-8351-4b30-8a08-de6d4f61e11a
📒 Files selected for processing (4)
CHANGELOG.mdcliff.tomldocs/build-system.mdscripts/check-doc-length.ts
Contributor
Benchmark Results407 benchmarks Interpreted: 🟢 19 improved · 🔴 174 regressed · 214 unchanged · avg -0.7% arraybuffer.js — Interp: 🔴 2, 12 unch. · avg -1.4% · Bytecode: 🔴 8, 6 unch. · avg -1.6%
arrays.js — Interp: 🔴 7, 12 unch. · avg -2.3% · Bytecode: 🔴 4, 15 unch. · avg -0.8%
async-await.js — Interp: 🔴 4, 2 unch. · avg -4.3% · Bytecode: 🔴 1, 5 unch. · avg -0.4%
async-generators.js — Interp: 2 unch. · avg -3.4% · Bytecode: 🔴 1, 1 unch. · avg -3.7%
base64.js — Interp: 🔴 4, 6 unch. · avg -1.8% · Bytecode: 🔴 1, 9 unch. · avg -1.6%
classes.js — Interp: 🔴 15, 16 unch. · avg -3.2% · Bytecode: 🟢 2, 🔴 1, 28 unch. · avg +0.4%
closures.js — Interp: 🔴 2, 9 unch. · avg -1.5% · Bytecode: 🔴 2, 9 unch. · avg -1.9%
collections.js — Interp: 🔴 10, 2 unch. · avg -3.7% · Bytecode: 🔴 7, 5 unch. · avg -2.7%
csv.js — Interp: 🔴 2, 11 unch. · avg -2.7% · Bytecode: 🟢 1, 🔴 2, 10 unch. · avg -0.4%
destructuring.js — Interp: 🔴 6, 16 unch. · avg -2.2% · Bytecode: 🟢 2, 🔴 4, 16 unch. · avg -1.0%
fibonacci.js — Interp: 🔴 7, 1 unch. · avg -3.8% · Bytecode: 🔴 1, 7 unch. · avg -0.9%
float16array.js — Interp: 🟢 1, 🔴 15, 16 unch. · avg -2.7% · Bytecode: 🟢 2, 🔴 9, 21 unch. · avg -1.2%
for-of.js — Interp: 🔴 6, 1 unch. · avg -4.3% · Bytecode: 7 unch. · avg -1.7%
generators.js — Interp: 🔴 1, 3 unch. · avg -2.9% · Bytecode: 4 unch. · avg -0.7%
iterators.js — Interp: 🔴 12, 30 unch. · avg -1.9% · Bytecode: 🟢 10, 🔴 5, 27 unch. · avg +0.5%
json.js — Interp: 🟢 1, 🔴 6, 13 unch. · avg -1.4% · Bytecode: 🔴 3, 17 unch. · avg -0.6%
jsx.jsx — Interp: 🔴 19, 2 unch. · avg -4.2% · Bytecode: 🟢 5, 🔴 4, 12 unch. · avg -0.5%
modules.js — Interp: 🔴 1, 8 unch. · avg -3.0% · Bytecode: 🟢 2, 🔴 4, 3 unch. · avg -1.4%
numbers.js — Interp: 🔴 1, 10 unch. · avg -2.1% · Bytecode: 🔴 1, 10 unch. · avg +0.2%
objects.js — Interp: 🔴 1, 6 unch. · avg -1.3% · Bytecode: 🔴 2, 5 unch. · avg -0.0%
promises.js — Interp: 🔴 9, 3 unch. · avg -5.3% · Bytecode: 🟢 1, 🔴 1, 10 unch. · avg +1.4%
regexp.js — Interp: 🔴 2, 9 unch. · avg -0.7% · Bytecode: 🔴 5, 6 unch. · avg -1.8%
strings.js — Interp: 🔴 9, 10 unch. · avg -1.6% · Bytecode: 🟢 1, 🔴 6, 12 unch. · avg -1.1%
tsv.js — Interp: 🔴 5, 4 unch. · avg -3.5% · Bytecode: 🔴 2, 7 unch. · avg -0.7%
typed-arrays.js — Interp: 🟢 5, 🔴 10, 7 unch. · avg +8.1% · Bytecode: 🟢 1, 🔴 9, 12 unch. · avg -4.7%
uint8array-encoding.js — Interp: 🟢 12, 🔴 4, 2 unch. · avg +40.8% · Bytecode: 🔴 11, 7 unch. · avg -20.3%
weak-collections.js — Interp: 🔴 14, 1 unch. · avg -19.9% · Bytecode: 🟢 14, 1 unch. · avg +51.4%
Measured on ubuntu-latest x64. Benchmark ranges compare cached main-branch min/max ops/sec with the PR run; overlapping ranges are treated as unchanged noise. Percentage deltas are secondary context. |
Contributor
Suite Timing
Measured on ubuntu-latest x64. |
frostney
force-pushed
the
t3code/website-changelog-fix
branch
from
23695ab to
3873a80
Compare
coderabbitai
Bot
added
documentation
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
website/into a dedicated changelog Website sectionnightlyis ignoredCHANGELOG.mdfrom the markdown document length checker