Skip to content

fix not working in windows because path (#30) #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 9, 2019
Merged

fix not working in windows because path (#30) #34

merged 3 commits into from
Apr 9, 2019

Conversation

@kltk
Copy link
Contributor

@kltk kltk commented Feb 15, 2019

#30

@frou
Copy link
Owner

frou commented Mar 30, 2019

It's valid to use basename here, but on the other hand, isn't this tackling the symptom rather than the problem? Why is Windows (or Git-for-Windows?) having a problem with an absolute path argument in the first place?

@frou frou merged commit bf4fda4 into frou:master Apr 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kltk @frou