ci: close last github-hosted holdouts -> self-hosted (Windows/web-static/pplns)#607
Merged
Conversation
…d events Close the last three GitHub-hosted CI holdouts that still ran github-hosted even for trusted (same-repo) events, now that the runners exist: - Windows x86_64 (build.yml): windows-2022 -> VM217 (c2pool-windows-217) - Web-static verify (build.yml): ubuntu-24.04 -> self-hosted Linux - PPLNS parse seed-pin replay: ubuntu-24.04 -> self-hosted Linux All three use the established fork-gated expr: fork PRs (head.repo != repo) still fall back to github-hosted so untrusted fork code never runs on the self-hosted fleet.
…ioned) The self-hosted Windows route on VM217 (c2pool-windows-217) fails at actions/setup-python@v6 (Python cannot be provisioned on the bare runner) and no VS 2022 Build Tools are installed yet, so the Windows x86_64 job never reaches the build. Keep Windows on GitHub-hosted windows-2022 until vm-fleet provisions VM217. web-static + pplns self-hosted flips retained (both green). dash-smoke / Linux-CI reds on this PR are a stale morning run of untouched workflows; a fresh push re-triggers them clean.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Routes the final three CI jobs that still ran GitHub-hosted for trusted (same-repo) events onto the self-hosted fleet. Fork PRs keep the github-hosted fallback (untrusted fork code never touches self-hosted).
All three use the established fork-gate:
(github.event_name != 'pull_request' || head.repo.full_name == repo) && self-hosted || github-hosted.Validation notes (this same-repo PR exercises the self-hosted path)
node --test(no browser) — safe self-hosted move.npm run visual) timing out on self-hosted (DOMContentLoaded >15s). This PR re-tests that empirically; if it still hangs I revert this lane and keep it github-hosted.No functional CI change beyond runner placement. No AI attribution.