ci: drop dash test targets from AsAN+UBSan build until spv-embedded lands#62
Merged
Merged
Conversation
…ands The .github/workflows/build.yml AsAN+UBSan build step references four dash-specific test targets (test_dash_credit_pool, test_dash_subsidy, test_dash_battletest_regressions, test_dash_pay_attribution) that do not yet exist on master. They live on the dash-spv-embedded branch (PR #43, 226-commit rebase in flight) where they were authored in commit 43ef108 Dash: unit tests for CreditPool + subsidy formulas. Result: every push to master fails the AsAN+UBSan job with gmake: *** No rule to make target test_dash_credit_pool. Stop. Regular Linux x86_64 build and the Coin matrix workflow do not list these targets and pass cleanly, so this is purely an AsAN-job-only workflow-master mismatch, not a code regression. Fix is tactical: remove the four target names so AsAN matches the regular Linux job. When dash-spv-embedded merges, the dash credit-pool PR can re-add them in the same PR that lands the tests, keeping the AsAN+UBSan job sanitizer-instrumented against the new code from day-one.
Owner
Author
MERGED at 6528ece + reviewer ACKsPR #62 squash-merged to master on operator approval. Master tip now Reviewer ACKs landed before merge
Tracked follow-upMemorialized in integrator task #42 description as an explicit dash-merge checklist item — when dash-spv-embedded merges, the four target names go back into Targets to restore:
Revert command (if needed)(single squash commit, clean revert; requires per-push approval per the standing rule) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The AsAN+UBSan job in
.github/workflows/build.ymlreferences four dash-specific test targets that do not exist on master:test_dash_credit_pooltest_dash_subsidytest_dash_battletest_regressionstest_dash_pay_attributionThese were authored on the
dash-spv-embeddedbranch in commit43ef108f(PR #43, 226-commit rebase in flight) and will land on master when that rebase completes.Symptom on every push to master
Why other jobs pass
LINK_GROUP:RESCANis GNU-ld-only; tracked under PR-CMake-object-library).Fix scope
Remove the two lines containing the four dash test references (lines 194-195) so the AsAN+UBSan target list matches the regular Linux job. No code/source change; CI workflow only.
When dash-spv-embedded lands
The dash author/reviewer can re-add the four target names in the same PR that lands the tests, keeping the AsAN+UBSan job sanitizer-instrumented from day one.
Verification
gh pr diffto confirm), strictly subtractive in YAMLci/asan-drop-dash-tests-until-spv-embedded-landsoff mastercd324735Test plan