ci(coin-matrix): fix BTC entrypoint gate (src/c2pool/main_<coin>.cpp)#66
Merged
Merged
Conversation
The presence check keyed on src/impl/<coin>/main_<coin>.cpp, but the per-coin entrypoint actually lives at src/c2pool/main_<coin>.cpp (the convention documented in the file header comment). The btc binary entrypoint is src/c2pool/main_btc.cpp with no src/impl/btc/main_btc.cpp, so the btc matrix job silently skipped as a false green. Gate now matches the real entrypoint path while retaining the src/impl/<coin>/ directory presence check.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The coin-matrix smoke gate keyed presence on
src/impl/<coin>/main_<coin>.cpp, but the per-coin entrypoint actually lives atsrc/c2pool/main_<coin>.cpp— the convention already documented in the file header comment.Why it matters
The BTC binary entrypoint is
src/c2pool/main_btc.cpp; there is nosrc/impl/btc/main_btc.cpp. So when btc source lands, thebtcmatrix job silently skips — a false green. This fix makes the gate match the real entrypoint path while retaining thesrc/impl/<coin>/directory check. Generalizes correctly across ltc/doge/dash/btc.Scope
One-line change to
.github/workflows/coin-matrix.yml. Independent of btc-heap-opt's btc-embedded preservation/rebase plan.Merge gated on operator push-approval.