Support for HF #40
Merged
Support for HF #40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Conditionally change based on if
hfexists in root node_modules.Changes
/static/hfdirectory.splitChunkswas causing issues for any files hf was loading via webpack.index.html => _index.htmlis so that we can serve it via express/ejs/snowwriteToDiskis so snow can serve the files based on the manifestMap provided by hf's webpack build.Testing
I created a prerelease of these changes and pushed it to prod via EF here: https://beta.familysearch.org/frontier/tyler-mvp/. The fact that it shows the green border around the page in helper mode means that it's working.