Fix zion rename and linting #78
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am now getting the invariant error about hooks outside a function component. I've tried looking through everything and it seems okay. I will need some help to figure this out. |
|
I thought this PR brought back the invariant hook error, but it's already there, so we should be able to merge this without anything getting worse |
redbugz
added a commit
that referenced
this pull request
Mar 16, 2019
* wagon wheel logo back in. made the readme a little more pared down and point to our docs. also included the travis badge in the readme * fixing spacing of comment for replacement during frontierInit * no need for manifest.json right now * 1.6.8 version bump * added error-boundary, user-provider, configured router, etc. * Add i18n Update blueprint to non-deprecated deliver section Update CIS/CAS to non-deprecated binding sets Various cleanups * running prettier on a file * removing HF and beefing up/fixing styleguidist and the tests (#72) * adding react and react-dom to the webpack.config.js alias section * 1.7.0 bump with react and react-dom aliases * Add i18n to CRA starter template (#73) * Add i18n to CRA starter template * Comment out deliver until blueprint is ready * Add versions to packages * Template also requires @emotion/styled * updating to the newly named zion components * incorporating Subnav into the template (#77) * Add prop-types to template (#76) * Restore Heroku prebuild (#79) We need the auth in Heroku or the builds will fail. If this was supposed to be removed, then we need a buildpack or other solution. * Fix zion rename and linting (#78) * Fix zion rename and linting issues * add i18next loader * Release 1.7.1 zion renames i18n add subnav add prop-types
joeycozza
added a commit
that referenced
this pull request
Apr 8, 2019
* wagon wheel logo back in. made the readme a little more pared down and point to our docs. also included the travis badge in the readme * fixing spacing of comment for replacement during frontierInit * no need for manifest.json right now * 1.6.8 version bump * added error-boundary, user-provider, configured router, etc. * Add i18n Update blueprint to non-deprecated deliver section Update CIS/CAS to non-deprecated binding sets Various cleanups * running prettier on a file * removing HF and beefing up/fixing styleguidist and the tests (#72) * adding react and react-dom to the webpack.config.js alias section * 1.7.0 bump with react and react-dom aliases * Add i18n to CRA starter template (#73) * Add i18n to CRA starter template * Comment out deliver until blueprint is ready * Add versions to packages * Template also requires @emotion/styled * updating to the newly named zion components * incorporating Subnav into the template (#77) * Add prop-types to template (#76) * Restore Heroku prebuild (#79) We need the auth in Heroku or the builds will fail. If this was supposed to be removed, then we need a buildpack or other solution. * Fix zion rename and linting (#78) * Fix zion rename and linting issues * add i18next loader * Release 1.7.1 zion renames i18n add subnav add prop-types * tweak home page style (#81) * tweak home page style * remove bg color * App styleguidist update and routing fixes (#82) * Update styleguidist config Fix routing when deployed * Update styleguidist config Fix routing when deployed * Release 1.7.2 * Move @fs/configurations webpack config into cra. * Add new package-lock * Add proxy to react-scripts * Copy over static assets from @fs and @fs-sandbox shared components. (#87) * Fix docs and remove exo from init * Update template to fix routing for home link (#88) * Fix env fallback for int (#89) REMOTE_ENV for int was not falling back correctly to default if the config var did not exist in int * patch bump
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.