Skip to content

fixade issue 491 #492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
georgelgeback merged 3 commits into from
Apr 23, 2026
Merged

fixade issue 491 #492

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4c684fb
fixat lite
erikmf123 Mar 5, 2026
97e72a3
Fix typo in error messages
georgelgeback Apr 23, 2026
7bd8f17
Merge remote-tracking branch 'origin/main' into SongsAuthenticationIs…
georgelgeback Apr 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions routes/song_router.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,10 @@ def update_song(song_id: int, song_data: SongCreate, db: DB_dependency):
if song is None:
raise HTTPException(status.HTTP_404_NOT_FOUND)

# simply check if the title is being changed to an already existing title, if so, throw an error.
num_existing = db.query(Song_DB).filter(Song_DB.title == song_data.title).count()
if num_existing > 0:
raise HTTPException(status.HTTP_400_BAD_REQUEST, detail="This song already exists")
# Allow for partial updates (kinda). We handle melody separately since we want to allow for None
for var, value in vars(song_data).items():
if value is not None:
Expand Down
Loading