Skip to content

Commit b1435b9

Browse files
dotnet-maestro[bot]baronfel
authored andcommitted
Update dependencies from https://github.com/dotnet/arcade build 20190725.15 (#7282)
- Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19375.15
1 parent 2c22a29 commit b1435b9

File tree

7 files changed

+39
-10
lines changed

7 files changed

+39
-10
lines changed

eng/Version.Details.xml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,9 +3,9 @@
33
<ProductDependencies>
44
</ProductDependencies>
55
<ToolsetDependencies>
6-
<Dependency Name="Microsoft.DotNet.Arcade.Sdk" Version="1.0.0-beta.19375.2">
6+
<Dependency Name="Microsoft.DotNet.Arcade.Sdk" Version="1.0.0-beta.19375.15">
77
<Uri>https://github.com/dotnet/arcade</Uri>
8-
<Sha>3dfa62fddcde597959c323d17426f215384e773a</Sha>
8+
<Sha>ef1c110152df0d500fffb87878a86f88d1ca5295</Sha>
99
</Dependency>
1010
</ToolsetDependencies>
1111
</Dependencies>

eng/common/init-tools-native.ps1

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -98,7 +98,7 @@ try {
9898
}
9999

100100
Write-Verbose "Installing $ToolName version $ToolVersion"
101-
Write-Verbose "Executing '$InstallerPath $LocalInstallerArguments'"
101+
Write-Verbose "Executing '$InstallerPath $($LocalInstallerArguments.Keys.ForEach({"-$_ '$($LocalInstallerArguments.$_)'"}) -join ' ')'"
102102
& $InstallerPath @LocalInstallerArguments
103103
if ($LASTEXITCODE -Ne "0") {
104104
$errMsg = "$ToolName installation failed"

eng/common/native/CommonLibrary.psm1

Lines changed: 31 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -59,9 +59,38 @@ function DownloadAndExtract {
5959
-Verbose:$Verbose
6060

6161
if ($UnzipStatus -Eq $False) {
62-
Write-Error "Unzip failed"
63-
return $False
62+
# Retry Download one more time with Force=true
63+
$DownloadRetryStatus = CommonLibrary\Get-File -Uri $Uri `
64+
-Path $TempToolPath `
65+
-DownloadRetries 1 `
66+
-RetryWaitTimeInSeconds $RetryWaitTimeInSeconds `
67+
-Force:$True `
68+
-Verbose:$Verbose
69+
70+
if ($DownloadRetryStatus -Eq $False) {
71+
Write-Error "Last attempt of download failed as well"
72+
return $False
73+
}
74+
75+
# Retry unzip again one more time with Force=true
76+
$UnzipRetryStatus = CommonLibrary\Expand-Zip -ZipPath $TempToolPath `
77+
-OutputDirectory $InstallDirectory `
78+
-Force:$True `
79+
-Verbose:$Verbose
80+
if ($UnzipRetryStatus -Eq $False)
81+
{
82+
Write-Error "Last attempt of unzip failed as well"
83+
# Clean up partial zips and extracts
84+
if (Test-Path $TempToolPath) {
85+
Remove-Item $TempToolPath -Force
86+
}
87+
if (Test-Path $InstallDirectory) {
88+
Remove-Item $InstallDirectory -Force -Recurse
89+
}
90+
return $False
91+
}
6492
}
93+
6594
return $True
6695
}
6796

eng/common/templates/post-build/channels/public-dev-release.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,7 @@ stages:
7777
filePath: eng\common\sdk-task.ps1
7878
arguments: -task PublishArtifactsInManifest -restore -msbuildEngine dotnet
7979
/p:ChannelId=$(PublicDevRelease_30_Channel_Id)
80-
/p:ArtifactsCategory=.NetCore
80+
/p:ArtifactsCategory=$(_DotNetArtifactsCategory)
8181
/p:IsStableBuild=$(IsStableBuild)
8282
/p:IsInternalBuild=$(IsInternalBuild)
8383
/p:RepositoryName=$(Build.Repository.Name)

eng/common/templates/post-build/channels/public-validation-release.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ stages:
4848
filePath: eng\common\sdk-task.ps1
4949
arguments: -task PublishArtifactsInManifest -restore -msbuildEngine dotnet
5050
/p:ChannelId=$(PublicValidationRelease_30_Channel_Id)
51-
/p:ArtifactsCategory=.NetCoreValidation
51+
/p:ArtifactsCategory=$(_DotNetArtifactsCategory)
5252
/p:IsStableBuild=$(IsStableBuild)
5353
/p:IsInternalBuild=$(IsInternalBuild)
5454
/p:RepositoryName=$(Build.Repository.Name)

eng/common/tools.sh

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,7 @@ function ReadGlobalVersion {
7777
local pattern="\"$key\" *: *\"(.*)\""
7878

7979
if [[ ! $line =~ $pattern ]]; then
80-
Write-PipelineTelemetryError -category 'InitializeTools' "Error: Cannot find \"$key\" in $global_json_file"
80+
Write-PipelineTelemetryError -category 'InitializeToolset' "Error: Cannot find \"$key\" in $global_json_file"
8181
ExitWithExitCode 1
8282
fi
8383

@@ -245,7 +245,7 @@ function InitializeNativeTools() {
245245
then
246246
local nativeArgs=""
247247
if [[ "$ci" == true ]]; then
248-
nativeArgs="-InstallDirectory $tools_dir"
248+
nativeArgs="--installDirectory $tools_dir"
249249
fi
250250
"$_script_dir/init-tools-native.sh" $nativeArgs
251251
fi

global.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
}
1111
},
1212
"msbuild-sdks": {
13-
"Microsoft.DotNet.Arcade.Sdk": "1.0.0-beta.19375.2",
13+
"Microsoft.DotNet.Arcade.Sdk": "1.0.0-beta.19375.15",
1414
"Microsoft.DotNet.Helix.Sdk": "2.0.0-beta.19069.2"
1515
}
1616
}

0 commit comments

Comments
 (0)