Skip to content

[WiP] PR to introduce a histogram chart type#89

Merged
simra merged 8 commits intofslaborg:masterfrom
bohdanszymanik:master
Oct 6, 2015
Merged

[WiP] PR to introduce a histogram chart type#89
simra merged 8 commits intofslaborg:masterfrom
bohdanszymanik:master

Conversation

@bohdanszymanik
Copy link
Copy Markdown
Contributor

And hopefully no issues

@simra
Copy link
Copy Markdown
Contributor

simra commented Oct 4, 2015

Checking in on this PR. Is the build failure a blocking issue? I don't have Gtk on my desktop (working on it), so I can't verify that it's an appveyor issue. Merging the PR on my personal branch to try it out now.

@bohdanszymanik
Copy link
Copy Markdown
Contributor Author

Whoops - I'm quite new to git/appveyor etc. I didn't get a build failure on my local gtk implementation but the xaxis labels wouldn't appear.

@simra
Copy link
Copy Markdown
Contributor

simra commented Oct 5, 2015

So am I. :) Since the build error has nothing to do with the specifics of the PR I suggest we accept the PR and open two issues- one for the build failure and the other for the labeling issue. If I don't get to it tonight I'll tackle this tomorrow.

@bohdanszymanik
Copy link
Copy Markdown
Contributor Author

I just tried that chocolatey install of gtksharp on a fairly vanilla win2012 server image - worked for me. Not sure why appveyor having issues.

@simra
Copy link
Copy Markdown
Contributor

simra commented Oct 6, 2015

Ok, merging. Labels display fine in Windows/WPF, so I'll create an issue for GtkSharp.

simra added a commit that referenced this pull request Oct 6, 2015
[WiP] PR to introduce a histogram chart type
@simra simra merged commit e4621f5 into fslaborg:master Oct 6, 2015
@dsyme
Copy link
Copy Markdown
Member

dsyme commented Oct 6, 2015

Nice addition!

@bohdanszymanik
Copy link
Copy Markdown
Contributor Author

Thanks! First time I've tried to do anything to contribute, it's a lot of fun.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants