Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello!
summary:
I added the
axrefandayreffields for the PlotlyAnnotations. I'm sorry if this wasn't the right way to address an issue for this repo. If it isn't, please let me know what I should do and I will be happy to go through the proper channels!long:
I was using the new and amazing .NET Interactive Notebooks extension in VSCode and was attempting to use annotations as a pseudo "vector". I was struggling with
axandaybeing tied to pixel values. I noticed the JS version has anayrefandaxrefbut XPlot doesn't. Looking through the code it seemed like all of the hard stuff would be handled for me if I just addedaxrefandayrefto the Annotation.fs file.It looks like it works. A quick modification to one of the tests/scripts/XPlot.Plotly/ fsx scripts generated a nice "vector" for me:
generates:

For the comments, I copied the
xrefandyrefcomments and modified them to sayaxandaysince they should be operating the same (I hope). Hopefully that is ok, but if I need to do more research on how it works and provide a better comment I'm happy to do so. Let me know what is required.I wasn't sure what kinds of tests, if any, might be required. If tests are required for new code. Let me know what I need to do. I wasn't sure.
Thanks!