create .NET Interactive extension package#155
Merged
cartermp merged 11 commits intofslaborg:masterfrom Feb 8, 2021
colombod:create_interactive_extension
Merged
create .NET Interactive extension package#155cartermp merged 11 commits intofslaborg:masterfrom colombod:create_interactive_extension
cartermp merged 11 commits intofslaborg:masterfrom
colombod:create_interactive_extension
Conversation
cartermp
requested changes
Feb 3, 2021
Collaborator
cartermp
left a comment
cartermp
left a comment
There was a problem hiding this comment.
To get CI to pass I think we'll also have to change the tool manifest file and pull in the very latest version of paket and fake-cli
Comment on lines
18
to
29
| let newScript = StringBuilder() | ||
| newScript.AppendLine("""<script type="text/javascript">""") |> ignore | ||
| newScript.AppendLine(""" | ||
| var renderPlotly = function() { | ||
| var xplotRequire = require.config({context:'xplot-3.0.1',paths:{plotly:'https://cdn.plot.ly/plotly-1.49.2.min'}}) || require; | ||
| xplotRequire(['plotly'], function(Plotly) {" """) |> ignore | ||
| newScript.AppendLine(script) |> ignore | ||
| newScript.AppendLine(@"}); | ||
| };" | ||
| ) |> ignore | ||
| newScript.AppendLine(JavascriptUtilities.GetCodeForEnsureRequireJs(Uri("https://cdnjs.cloudflare.com/ajax/libs/require.js/2.3.6/require.min.js"), "renderPlotly")) |> ignore | ||
| newScript.ToString() |
Collaborator
There was a problem hiding this comment.
Just for fun, this can now be an interpolated string since it's using the .NET 5 SDK
daxian-dbw
reviewed
Feb 4, 2021
NuGet.config
Outdated
| <add key="dotnet3-dev" value="https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet3.1/nuget/v3/index.json" /> | ||
| <add key="dotnet5" value="https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet5/nuget/v3/index.json" /> | ||
| <add key="MachineLearning" value="https://pkgs.dev.azure.com/dnceng/public/_packaging/MachineLearning/nuget/v3/index.json" /> | ||
| <add key="PSGallery" value="https://www.powershellgallery.com/api/v2/" /> |
There was a problem hiding this comment.
Unless you are going to pull PowerShell modules in this repo, this feed probably should be removed.
Collaborator
Author
There was a problem hiding this comment.
I think I have to implement in this repo the code that the powershell kernel was doing to integrate the xplot types. What do you think?
There was a problem hiding this comment.
Yes, the New-PlotyChart cmdlet needs to be moved here. But the PSGallery is not needed for that. You will need to reference to PowerShellStandard.Library.
daxian-dbw
reviewed
Feb 8, 2021
Comment on lines
21
to
23
| override _.BeginProcessing() = () | ||
|
|
||
| override _.ProcessRecord() = () |
There was a problem hiding this comment.
Please do the same as the original implementation. This makes sure the piping behavior is as expected.
private List<Trace> _traces;
/// <summary>
/// BeginProcessing override.
/// </summary>
protected override void BeginProcessing()
{
_traces = new List<Trace>();
}
/// <summary>
/// ProcessRecord override.
/// </summary>
protected override void ProcessRecord()
{
_traces.AddRange(Trace);
}
NuGet.config
Outdated
| <add key="dotnet3-dev" value="https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet3.1/nuget/v3/index.json" /> | ||
| <add key="dotnet5" value="https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet5/nuget/v3/index.json" /> | ||
| <add key="MachineLearning" value="https://pkgs.dev.azure.com/dnceng/public/_packaging/MachineLearning/nuget/v3/index.json" /> | ||
| <add key="PSGallery" value="https://www.powershellgallery.com/api/v2/" /> |
jonsequitur
approved these changes
Feb 8, 2021
daxian-dbw
reviewed
Feb 8, 2021
|
|
||
|
|
||
| override this.EndProcessing() = | ||
| let traces = if isNull this.Trace then [||] else this.Trace |
cartermp
approved these changes
Feb 8, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add .NET Interactive extension pakcage