Skip to content

Replace FSharpOption with Option when emitting F# #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dsyme merged 1 commit into from Jan 8, 2017
Merged

Replace FSharpOption with Option when emitting F# #20

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion src/FSharp.Compiler.CodeDom/CodeGenerator.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -445,8 +445,14 @@ and getBaseTypeRef (cr:CodeTypeReference) renames (ns:string) (tyParams:Set<stri
i <- i + 1
| _ -> sb.Append(c) |> ignore
i <- i + 1

// generate type arguments
sb.Append(getTypeArgs cr.TypeArguments renames ns tyParams fsSyntax).ToString()
let gta = getTypeArgs cr.TypeArguments renames ns tyParams fsSyntax

// Check for standard F# generic types
match sb.ToString() with
| "Microsoft.FSharp.Core.FSharpOption" -> "Option" + gta
| _ -> sb.Append(gta) |> fun x -> x.ToString()

/// Generate type reference with empty context
and getBaseTypeRefString (s:string) =
Expand Down