Skip to content

get reference documentation output from build again#100

Merged
wilsoncg merged 1 commit intofsprojects:masterfrom
wilsoncg:master
Jan 11, 2019
Merged

get reference documentation output from build again#100
wilsoncg merged 1 commit intofsprojects:masterfrom
wilsoncg:master

Conversation

@wilsoncg
Copy link
Copy Markdown
Contributor

@wilsoncg wilsoncg commented Jan 1, 2019

Use FSharp.Core.dll shipped in fakebuild nuget package instead for reference documentation generation only #85.

I'm confident this change will not break the CI build as the generate documentation targets are not called.

(use FSharp.Core.dll shipped in fakebuild nuget package instead)
@dsyme
Copy link
Copy Markdown
Contributor

dsyme commented Jan 8, 2019

@eulerfx You good to merge this?

@dsyme
Copy link
Copy Markdown
Contributor

dsyme commented Jan 8, 2019

@wilsoncg Nice fix. I'm wondering if it might make sense to have a second maintainer, are you interested? Currently myself, @tpetricek and @eulerfx are listed as maintainers, though most recently it's just been @eulerfx, with myself as backup.

@wilsoncg
Copy link
Copy Markdown
Contributor Author

wilsoncg commented Jan 8, 2019

Sure @dsyme, I'd be happy to ease the burden from yourself, @tpetricek and @eulerfx.

@dsyme
Copy link
Copy Markdown
Contributor

dsyme commented Jan 9, 2019

@wilsoncg Cool, I'm checking with @eulerfx and if he approves I'll give you the necessary permissions

@eulerfx
Copy link
Copy Markdown
Contributor

eulerfx commented Jan 10, 2019

Yes please, we could use the help. Much appreciated @wilsoncg

@wilsoncg wilsoncg merged commit fbac79b into fsprojects:master Jan 11, 2019
@dsyme
Copy link
Copy Markdown
Contributor

dsyme commented Jan 14, 2019

@wilsoncg I haven't given you permission for the nuget package yet @eulerfx Could you give @wilsoncg permission on that please? Thanks

@dsyme
Copy link
Copy Markdown
Contributor

dsyme commented Feb 26, 2019

@wilsoncg What is your nuget handle? thanks

@wilsoncg
Copy link
Copy Markdown
Contributor Author

wilsoncg commented Jun 9, 2019

@dsyme Sorry, I just got round to doing the necessary for nuget, my nuget handle is wilsoncg.

Could not push D:\projects\fsharp\FSharp.Control.AsyncSeq\bin\FSharp.Control.AsyncSeq.2.0.22.nupkg: The remote server returned an error: (403) Forbidden.

Am I right in saying after you do the necessary in nuget then I will not receive this 403 error?

@dsyme
Copy link
Copy Markdown
Contributor

dsyme commented Jul 2, 2019

@wilsoncg Apologies for the delay, I've sent you an invitation to be nuget package co-owner. AFAICS the above error should go after you accept the request.

@wilsoncg
Copy link
Copy Markdown
Contributor Author

wilsoncg commented Jul 2, 2019

@dsyme Thanks for sorting out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants