fix AsyncSeq.scanAsync #11#16
Merged
dsyme merged 3 commits intofsprojects:masterfrom Mar 28, 2015
eulerfx:master
Merged
Conversation
Contributor
There was a problem hiding this comment.
I think it's better to stay idiomatic and use
asyncSeq { yield state; yield! go f state input }
Contributor
|
One comment, otherwise LGTM |
Contributor
Author
|
Done. This would make for an easier change to let inline cons (head:'T) (tail:AsyncSeq<'T>) : AsyncSeq<'T> =
asyncSeq { yield head ; yield! tail } |
Contributor
|
I think you should feel free to submit PRs for correct and tested versions of any of the Seq.* functions or async variations of them (e.g. mapAsync - though we already have that). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.