Skip to content

fix AsyncSeq.scanAsync #11#16

Merged
dsyme merged 3 commits intofsprojects:masterfrom
eulerfx:master
Mar 28, 2015
Merged

fix AsyncSeq.scanAsync #11#16
dsyme merged 3 commits intofsprojects:masterfrom
eulerfx:master

Conversation

@eulerfx
Copy link
Copy Markdown
Contributor

@eulerfx eulerfx commented Mar 28, 2015

No description provided.

Comment thread src/FSharp.Control.AsyncSeq/AsyncSeq.fs Outdated
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's better to stay idiomatic and use

asyncSeq { yield state; yield! go f state input }

@dsyme
Copy link
Copy Markdown
Contributor

dsyme commented Mar 28, 2015

One comment, otherwise LGTM

@eulerfx
Copy link
Copy Markdown
Contributor Author

eulerfx commented Mar 28, 2015

Done. This would make for an easier change to IAsyncEnumerable. Maybe a cons function makes sense:

  let inline cons (head:'T) (tail:AsyncSeq<'T>) : AsyncSeq<'T> =
    asyncSeq { yield head ; yield! tail }

@dsyme
Copy link
Copy Markdown
Contributor

dsyme commented Mar 28, 2015

I think you should feel free to submit PRs for correct and tested versions of any of the Seq.* functions or async variations of them (e.g. mapAsync - though we already have that).

dsyme added a commit that referenced this pull request Mar 28, 2015
@dsyme dsyme merged commit 8c6cebe into fsprojects:master Mar 28, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants