Conversation
There was a problem hiding this comment.
Great work. Could you also please add a more systematic test that covers a wider range of input sizes and buffer sizes? e.g. compare to the tests I've been adding recently which always have some kind of "for" loop at the outer to cover a range of scenarios. thanks
There was a problem hiding this comment.
Do you think FsCheck would make sense?
There was a problem hiding this comment.
Yes, almost certainly would help, though I've not much experience in driving it
There was a problem hiding this comment.
Most of the rest of the code uses "while" loops, for better or worse. These use a Landin's-knot like trick to amortize the allocation that controls the loop. You may want to compare perf between these approaches at some point.
No description provided.