Skip to content

Updated vulnerable NuGet.* packages to 6.14.3#8

Merged
xperiandri merged 1 commit into
mainfrom
CentralPackageTransitivePinning
May 23, 2026
Merged

Updated vulnerable NuGet.* packages to 6.14.3#8
xperiandri merged 1 commit into
mainfrom
CentralPackageTransitivePinning

Conversation

@xperiandri
Copy link
Copy Markdown
Collaborator

@xperiandri xperiandri commented May 23, 2026

Proposed Changes

Enables Central Package Transitive Pinning (CentralPackageTransitivePinningEnabled) in Directory.Build.props so that all transitive NuGet dependencies are resolved exclusively from the versions declared in Directory.Packages.props. As a direct consequence, several vulnerable or outdated transitive packages are pinned explicitly: NuGet.Common and NuGet.Protocol are upgraded from 6.11.1 to 6.14.3, and NuGet.Packaging, System.Drawing.Common, and System.Formats.Asn1 are added as explicit version pins to satisfy security advisories. The SDK is updated to 10.0.300 and the legacy .sln file is replaced by the newer .slnx format. All GitHub Actions workflows are updated to their latest action versions.

Types of changes

What types of changes does your code introduce to FSharp.Control.R3?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • Build and tests pass locally
  • I have added tests that prove my fix is effective or that my feature works (if appropriate) – not applicable; this is a dependency/tooling update with no logic changes
  • I have added necessary documentation (if appropriate) – not applicable; no public API changes

Further comments

Transitive pinning is enforced by adding <CentralPackageTransitivePinningEnabled>true</CentralPackageTransitivePinningEnabled> to Directory.Build.props. This requires that any transitive package whose resolved version must be overridden is listed explicitly in Directory.Packages.props – hence the addition of NuGet.Packaging, System.Drawing.Common, and System.Formats.Asn1 entries. Without these pins the build would fail under the new pinning policy.

* Upgraded `NuGet.Common` and `NuGet.Protocol` from `6.14.0` to `6.14.3` in Directory.Packages.props to incorporate the latest bug fixes and improvements
* Enabled `CentralPackageTransitivePinningEnabled`
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR strengthens dependency and restore hygiene by moving the repo toward fully centrally-pinned package resolution, and updates specific NuGet-related packages to patched versions.

Changes:

  • Enabled Central Package Transitive Pinning (CentralPackageTransitivePinningEnabled) to ensure transitive dependency versions are centrally governed.
  • Updated NuGet.Common and NuGet.Protocol to 6.14.3 and added explicit pins for additional packages needed under the new pinning policy.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
Directory.Packages.props Updates/pins NuGet-related and security-advisory-related package versions under central package management.
Directory.Build.props Enables transitive pinning to enforce central version control for transitive restores.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@xperiandri xperiandri merged commit 7a6362e into main May 23, 2026
8 checks passed
@xperiandri xperiandri deleted the CentralPackageTransitivePinning branch May 23, 2026 02:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants