[Repo Assist] perf: use while! in tryTail inner loop, removing redundant mutable go flag#388
Draft
github-actions[bot] wants to merge 2 commits intomainfrom
Draft
Conversation
… flag Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 This is an automated pull request from Repo Assist, an AI assistant.
Summary
Converts the inner
taskSeqloop intryTailfrom the manualgo-flag + initial-MoveNext pre-advance pattern to the idiomaticwhile!form.Before
After
Context
This is part of a broader series (#382, #386) replacing the old manual pre-advance idiom with the idiomatic
while!CE operator, which:gobool per functionlet! step = e.MoveNextAsync(); go <- stepbefore the loopScope
Single-function change:
tryTail. No public API or behaviour change.Trade-offs
None. Identical semantics, verified by the full test suite.
Test Status
✅ Build: 0 warnings, 0 errors (Release, Linux)
✅ Fantomas: formatting check passes
✅ Tests: 5093 passed, 2 skipped, 0 failed