Add a Schema option for JsonProvider#1523
Conversation
EverybodyKurts
force-pushed
the
feature/json-schema-provider
branch
from
a4e82a7 to
b406d46
Compare
|
@EverybodyKurts I'll do the review. @cartermp Would be great if you could take a look too |
|
@EverybodyKurts It's a really great piece of work, also updating the engineering. Would you like to be co-maintainer on this repo going forward too? Thanks 🚀 😄 🙏 |
|
|
||
| /// Specifies the formatting behaviour of JSON values | ||
| [<RequireQualifiedAccess>] | ||
| // [<RequireQualifiedAccess>] |
There was a problem hiding this comment.
I think maybe this should not have been commented out?
| @@ -0,0 +1,64 @@ | |||
| { | |||
There was a problem hiding this comment.
Was wondering if this should also covre URIs and any other types in the JSON schema type
dsyme
left a comment
dsyme
left a comment
There was a problem hiding this comment.
@EverybodyKurts This is an incredible piece of work - really clean and I love that you've both added the testing and updated the engineering.
I've left two small comments, I think they can be addressed in follow-up PR
@dsyme It would be an honor and a pleasure. I appreciate the work you and the developers on this project have done over the years. This is a feature I've been wanting to add for awhile. I'm glad I was able to help contribute to it in a meaningful way. |
2 participants
This pull request adds a
Schemaoption toJsonProviderthat mirrors theSchemaoption forXmlProvider. It accepts either a JSON Schema string or file and likeXmlProvider, it allows the developer to access JSON documents in a statically typed way.Please note that I used claude.ai to help me write this code, tests, and documentation.