[repo-assist] eng: remove AssemblyInfo files; use SDK-generated assembly attributes#1776
Merged
dsyme merged 2 commits intoMay 10, 2026
Conversation
- Delete all src/AssemblyInfo*.fs files (FAKE-generated, legacy approach) - Delete tests/.../Properties/AssemblyInfo.cs (unused dead code) - Remove GenerateAssemblyInfo=false and Compile includes from all .fsproj files - Add Product and AssemblyDescription to Directory.Build.props (shared values) - Pass Version to the Build MSBuild step so assemblies get the right version - Remove AssemblyInfo FAKE target and dep from build pipeline - Remove Fake.DotNet.AssemblyInfoFile from build/paket.references - Bump version to 8.1.14 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
dsyme
deleted the
repo-assist/eng-remove-assemblyinfo-files-2026-05-09-56d79a4a370128b1
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 This is an automated pull request from Repo Assist, an AI assistant for this repository.
Closes #1775
What
Removes the legacy FAKE-generated
AssemblyInfo*.fsfiles and the unusedProperties/AssemblyInfo.csin the CSharp test project, switching to the standard SDK assembly-info generation.Changes
src/AssemblyInfo*.fsfiles (were auto-generated by FAKE)tests/FSharp.Data.Core.Tests.CSharp/Properties/AssemblyInfo.cs(dead code — excluded from compile byEnableDefaultCompileItems=false)<GenerateAssemblyInfo>false</GenerateAssemblyInfo>and<Compile Include="../AssemblyInfo*.fs" />from all 9.fsprojfiles insrc/<Product>FSharp.Data</Product>and<AssemblyDescription>toDirectory.Build.props(shared values)BuildFAKE target to pass-p:Version=<nuget-version>to MSBuild so the assembly version is set correctly fromRELEASE_NOTES.mdAssemblyInfoFAKE target and its dependency in the build pipeline ("Clean" ==> "AssemblyInfo" ==> "CheckFormat" ==> "Build"→"Clean" ==> "CheckFormat" ==> "Build")Fake.DotNet.AssemblyInfoFilefrombuild/paket.references8.1.14inRELEASE_NOTES.mdThe
AssemblyTitleattribute is set automatically by the SDK to match the assembly name (e.g.FSharp.Data.Http), which is correct for all projects.Test Status