Optional range information for Markdown elements

[artempyanykh]

I'm looking into using the Markdown parser for a project, but noticed that the range information is optional for markdown elements. Glancing through the code I can see only 1 place where the range can become None but this looks accidental. Am I missing something? Or the range indeed should be present for all elements in the real world scenarios.

[dsyme]

@artempyanykh Yes, makes sense - please do submit a PR to make the ranges non-optional

[artempyanykh]

@dsyme thanks! I looked into it and it seems that something's off with some span ranges (potentially around links). It seems that markdown ranges need a bit more love than I can give ATM, but anyhow I filed a separate issue specifically around correctness of ranges in case things change #744.

[github-actions]

🤖 This is an automated response from Repo Assist.

This issue is closely related to #744 (incorrect span ranges in Markdown elements). In the previous run I identified the root cause of #744: the parseChars function in MarkdownParser.fs does not advance the StartColumn past inline spans, so spans such as DirectLink, IndirectLink, and Emphasis have their end range incorrectly set to the start of the span rather than after the closing delimiter.

Before making ranges non-optional (as @dsyme suggested), it would be worth fixing the range correctness issue in #744 first — otherwise we'd be promoting incorrect ranges to required values, making any consumer that relies on precise positions silently wrong.

The two issues could be addressed together in a single PR:

1. Fix the parseChars column-advance bug (Markdown: some spans have incorrect ranges #744)
2. Make ranges non-optional once they are trustworthy (Optional range information for Markdown elements #742)

Happy to draft a PR for this if there's maintainer interest.

Generated by Repo Assist

To install this workflow, run gh aw add githubnext/agentics/workflows/repo-assist.md@b87234850bf9664d198f28a02df0f937d0447295. View source at https://github.com/githubnext/agentics/tree/b87234850bf9664d198f28a02df0f937d0447295/workflows/repo-assist.md.

[dsyme]

/repo-assist fix this please

[github-actions]

Pull request created: #1067

Generated by Repo Assist

[github-actions]

🤖 This is an automated response from Repo Assist.

Done! I've created a draft PR that makes MarkdownRange non-optional throughout the Markdown AST.

Changes in the PR:

• All range: MarkdownRange option fields in MarkdownSpan and MarkdownParagraph → range: MarkdownRange
• MarkdownRange.zero used as the fallback where no range is available
• ParsingContext.CurrentRange simplified to MarkdownRange (non-optional)
• All internal parsers and Literate formatting code updated
• Test expectations updated

All 257 tests pass. This is a breaking API change for consumers that pattern-match on range fields.

The PR is at: https://github.com/fsprojects/FSharp.Formatting/pulls?q=is%3Apr+is%3Aopen+%22non-optional+ranges%22

Generated by Repo Assist for issue #742

To install this agentic workflow, run

gh aw add githubnext/agentics/workflows/repo-assist.md@da02dddebe71d9a937665abdcd1f5214dab852a7