[Repo Assist] refactor: extract formatListBlock helper — eliminate ordered/unordered list duplication in MarkdownUtils.fs#1176
Closed
github-actions[bot] wants to merge 2 commits intomainfrom
Conversation
…ed list duplication in MarkdownUtils.fs Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 This PR was created by Repo Assist, an automated AI assistant.
Summary
Task 5 (Coding Improvements): the
formatParagraphfunction inMarkdownUtils.fshad two near-identical blocks for formatting ordered and unordered lists — differing only in the item prefix ("* "vs"1. ","2. ", ...). This PR extracts a sharedformatListBlockhelper, reducing ~48 lines to ~27 lines with no semantic change.Before
After
Changes
src/FSharp.Formatting.Markdown/MarkdownUtils.fsformatListBlockhelper, remove ~21 duplicate linesRELEASE_NOTES.md[Unreleased]Test Status
dotnet build src/FSharp.Formatting.Markdown/FSharp.Formatting.Markdown.fsproj --configuration Release— 0 warnings, 0 errorsdotnet test tests/FSharp.Markdown.Tests— 346/346 passed (includes existing list round-trip tests)dotnet fantomas src/FSharp.Formatting.Markdown/MarkdownUtils.fs --check— formatting verified