Skip to content

Update FSharp.Compiler.Service to 43.10.100 #966

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 12, 2025
Merged

Update FSharp.Compiler.Service to 43.10.100 #966

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2e03d2d
Update FSharp.Compiler.Service to 43.10.100
TheAngryByrd Nov 12, 2025
e809dc8
Merge branch 'main' into update-fcs-43-10-100
nojaf Nov 12, 2025
5ed3222
Add release note entry
nojaf Nov 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Directory.Packages.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,8 @@
</PropertyGroup>
<ItemGroup>
<!-- locking the version of F# Core as FCS does this anyway and in practise all will be using the same version -->
<PackageVersion Include="FSharp.Core" Version="[9.0.100]" />
<PackageVersion Include="FSharp.Compiler.Service" Version="[43.9.100]" />
<PackageVersion Include="FSharp.Core" Version="[10.0.100]" />
<PackageVersion Include="FSharp.Compiler.Service" Version="[43.10.100]" />
<PackageVersion Include="CommandLineParser" Version="2.9.1" />
<PackageVersion Include="Microsoft.Build" Version="" PrivateAssets="all" />
<PackageVersion Include="Microsoft.Build.Framework" Version="" PrivateAssets="all" />
Expand Down
5 changes: 5 additions & 0 deletions RELEASE_NOTES.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,10 @@
# Changelog

## [Unreleased]

### Changed
* Update FCS to 43.10.100. [#935](https://github.com/fsprojects/FSharp.Formatting/pull/966)

## 21.0.0 - 2025-11-12

Stable release
Expand Down
36 changes: 22 additions & 14 deletions src/FSharp.Formatting.ApiDocs/GenerateModel.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1385,12 +1385,12 @@ module internal SymbolReader =

let readMemberOrVal (ctx: ReadingContext) (v: FSharpMemberOrFunctionOrValue) =
let requireQualifiedAccess =
hasAttrib<RequireQualifiedAccessAttribute> v.ApparentEnclosingEntity.Attributes
// Hack for FSHarp.Core - `Option` module doesn't have RQA but really should have
|| (v.ApparentEnclosingEntity.Namespace = Some "Microsoft.FSharp.Core"
&& v.ApparentEnclosingEntity.DisplayName = "Option")
|| (v.ApparentEnclosingEntity.Namespace = Some "Microsoft.FSharp.Core"
&& v.ApparentEnclosingEntity.DisplayName = "ValueOption")
v.ApparentEnclosingEntity
|> Option.exists (fun aee ->
hasAttrib<RequireQualifiedAccessAttribute> aee.Attributes
// Hack for FSHarp.Core - `Option` module doesn't have RQA but really should have
|| (aee.Namespace = Some "Microsoft.FSharp.Core" && aee.DisplayName = "Option")
|| (aee.Namespace = Some "Microsoft.FSharp.Core" && aee.DisplayName = "ValueOption"))

let customOpName =
match tryFindAttrib<CustomOperationAttribute> v.Attributes with
Expand All @@ -1406,7 +1406,8 @@ module internal SymbolReader =
// This module doesn't have RequireQualifiedAccessAttribute and anyway we want the name to show
// usage of its members as Array.Parallel.map
let specialCase1 =
v.ApparentEnclosingEntity.TryFullName = Some "Microsoft.FSharp.Collections.ArrayModule.Parallel"
v.ApparentEnclosingEntity
|> Option.exists (fun aee -> aee.TryFullName = Some "Microsoft.FSharp.Collections.ArrayModule.Parallel")

let argInfos, retInfo = FSharpType.Prettify(v.CurriedParameterGroups, v.ReturnParameter)

Expand Down Expand Up @@ -1439,7 +1440,13 @@ module internal SymbolReader =

match v.IsMember, v.IsInstanceMember, v.LogicalName, v.DisplayName, customOpName with
// Constructors
| _, _, ".ctor", _, _ -> span [] [ !!v.ApparentEnclosingEntity.DisplayName; fullArgUsage ]
| _, _, ".ctor", _, _ ->
span
[]
[ match v.ApparentEnclosingEntity with
| None -> ()
| Some aee -> !!aee.DisplayName
fullArgUsage ]

// Indexers
| _, true, _, "Item", _ -> span [] [ !! "this["; fullArgUsage; !! "]" ]
Expand Down Expand Up @@ -1515,7 +1522,9 @@ module internal SymbolReader =
| _, false, _, name, _ ->
span
[]
[ !!(v.ApparentEnclosingEntity.DisplayName + "." + name)
[ match v.ApparentEnclosingEntity with
| None -> !!name
| Some aee -> !!(aee.DisplayName + "." + name)
if preferNoParens then
!! "&#32;"
fullArgUsage ]
Expand Down Expand Up @@ -1552,7 +1561,7 @@ module internal SymbolReader =
// Hence getting the generic argument count if this is a little trickier
let numGenericParamsOfApparentParent =
let pty = v.ApparentEnclosingEntity
pty.GenericParameters.Count
pty |> Option.map _.GenericParameters.Count |> Option.defaultValue 0

// Ensure that there is enough number of elements to skip
let tps =
Expand Down Expand Up @@ -1586,10 +1595,9 @@ module internal SymbolReader =
let extendedType =
if v.IsExtensionMember then
try
Some(
v.ApparentEnclosingEntity,
formatTyconRefAsHtml ctx.UrlMap v.ApparentEnclosingEntity |> codeHtml
)
match v.ApparentEnclosingEntity with
| Some aee -> Some(aee, formatTyconRefAsHtml ctx.UrlMap aee |> codeHtml)
| None -> None
with _ ->
None
else
Expand Down