Is the 'deployReleaseBinaries' CI build step supposed to run the unit tests 3 times?

[Numpsy]

This is just an observation after looking at the current build issues rather than a bug, but I'm putting it in its own issue rather than just in a comment in an unrelated PR:

Looking at the CI build logs, it looks like the deployReleaseBinaries CI stage is running the unit tests 3 times -

Once in the 'build' step - https://github.com/fsprojects/FSharpLint/actions/runs/19330699804/job/55293390736#step:4:55
Then again in the 'pack' step - https://github.com/fsprojects/FSharpLint/actions/runs/19330699804/job/55293390736#step:5:68
Then a 3rd time in the 'upload binaries to nuget' step - https://github.com/fsprojects/FSharpLint/actions/runs/19330699804/job/55293390736#step:8:64

This seems a tad spurious, and also looks like it adds several minutes to the build times?

[knocte]

Thanks for raising this. I believe we have a bug in how the target dependencies are set up (see the end of the build.fsx file).

Also, we should split the target "Test" in two: one that just builds the tests ("Test"), and another one that runs them ("Check").

Then the target "Test" should depend on "Build", but not "Check". The target "Check" should depend on "Test". The target "Release" should depend on "Check". The target "Pack" should depend on "Release". The target "Push" should depend on "Pack" and so on.

Feel free to create a PR.