DRAFT: Add new rule IndexerAccessorStyleConsistency #557
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add .vscode to .gitignore
parhamsaremi
force-pushed
the
issue532-squashed-fixed
branch
from
a8e55ba to
98f3cbd
Compare
parhamsaremi
changed the title
knocte
reviewed
Jul 23, 2022
| | _ -> | ||
| Array.empty | ||
| else | ||
| failwith (String.Format("Unknown style type %s", styleType)) |
Collaborator
There was a problem hiding this comment.
@parhamsaremi nit: in F#, it's better not to use String.Format for string replacement, but rather sprintf, printf, failwithf, etc (please see F# tutorial for reference)
knocte
reviewed
Jul 23, 2022
src/FSharpLint.Core/Text.resx
Outdated
| <value>Consider using a longer name, as it is currently too short.</value> | ||
| </data> | ||
| <data name="RulesIndexerAccessorStyleConsistency" xml:space="preserve"> | ||
| <value>Consider switching the style for indexer accessing from OCaml to CSharp or viceversa.</value> |
knocte
reviewed
Jul 23, 2022
docs/content/how-tos/rules/FL0077.md
Outdated
|
|
||
| ## Rationale | ||
|
|
||
| F# 6.0 introduces a new style for indexer accessor, similar to the one in C#. But it's convenient for our codebase to be consistent in which accessor to use. |
Collaborator
There was a problem hiding this comment.
@parhamsaremi which accessor -> which accessor style
knocte
reviewed
Jul 23, 2022
|
|
||
| let generateOutput (range: FSharp.Compiler.Text.Range) (styleMain: string) (styleError: string) = | ||
| { Range = range | ||
| Message = String.Format ("You must use %s styling instead of %s for indexer accessing", styleMain, styleError) |
parhamsaremi
force-pushed
the
issue532-squashed-fixed
branch
2 times, most recently
from
51c2871 to
7cf80f6
Compare
Checks for OCaml and CSharp styles. Fixes fsprojects#532
parhamsaremi
force-pushed
the
issue532-squashed-fixed
branch
from
7cf80f6 to
dcf2cc4
Compare
parhamsaremi
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checks for OCaml and CSharp styles. Fixes #532