FailwithBadUsage: fixed case with failwithf application #764
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed case when failwithf is used with arguments, like `failwithf "bar %i" 42`.
The failwithf func was not being tested properly with an arg.
knocte
force-pushed
the
wip/failwithBadUsageBug
branch
2 times, most recently
from
88d814c to
becbf68
Compare
This might likely fix the flaky tests that we started getting lately. Maybe they were exposed by some recent change that made them run in parallel [1]. [1] ca158b8 Closes fsprojects#763
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed case when failwithf is used with arguments, like
failwithf "bar %i" 42.