Skip to content

Conversation

@Numpsy
Copy link
Contributor

@Numpsy Numpsy commented Sep 8, 2025

The FSharp.Core dependency in Fornax.Core has been changed from = 8.0.100 to >= 6.0.7 which should hopefully fix these warnings in the docs build:

image

@knocte
Copy link
Collaborator

knocte commented Sep 9, 2025

@Numpsy thanks for the PR! Can you please sync the commit msg with the PR description please? Otherwise the commit message only includes the what but not the why.

@Numpsy Numpsy force-pushed the fornax_0.16.0-beta005 branch from 0aabb4b to 808c048 Compare September 9, 2025 11:28
@Numpsy
Copy link
Contributor Author

Numpsy commented Sep 9, 2025

commit comment updated

@Numpsy Numpsy force-pushed the fornax_0.16.0-beta005 branch 2 times, most recently from b5fb915 to 915e0bb Compare November 3, 2025 21:53
@knocte
Copy link
Collaborator

knocte commented Nov 5, 2025

I'm actually wondering, shouldn't we turn on Warnings As Errors in order to catch this kind of things earlier?

@Numpsy
Copy link
Contributor Author

Numpsy commented Nov 5, 2025

Warnings as errors is turned on for the main build at

<TreatWarningsAsErrors>true</TreatWarningsAsErrors>
but if these warnings are from executing the Fornax tool then maybe that doesn't pick up those settings.

@Numpsy Numpsy force-pushed the fornax_0.16.0-beta005 branch from 915e0bb to 00e5fff Compare November 5, 2025 16:06
@Numpsy
Copy link
Contributor Author

Numpsy commented Nov 10, 2025

Fornax 0.16.0 release is out now, I'll update the PR to that

@Numpsy Numpsy force-pushed the fornax_0.16.0-beta005 branch from 00e5fff to 727a4f2 Compare November 10, 2025 13:09
The FSharp.Core dependency in Fornax.Core has been changed from = 8.0.100 to >= 6.0.7 which should fix some dependency constraint warnings in the build
@Numpsy Numpsy changed the title Update Fornax to 0.16.0-beta005 Update Fornax to 0.16.0 Nov 10, 2025
@knocte knocte merged commit c53b6d8 into fsprojects:master Nov 10, 2025
6 checks passed
@Numpsy Numpsy deleted the fornax_0.16.0-beta005 branch November 10, 2025 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants