Update .NET version & drop setup steps to fix CI #780
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated .NET9.x minor version and dropped setup-.NET steps in GitHubActions in order to fix CI build of the `docs` job. Somehow, on the same day as the .NETv10 release, our CI started failing without changing anything (thanks to our `on: schedule: cron:` trigger we detected this, as it runs daily), but only in the docs job. After some discussion about Fornax in PRs 770 and 779 (given that we updated this dep in PR#767 recently), it was discovered that the default .NET version of current GitHubActions agents works out of of the box without needing to run any setup-dotnet action. So then, rather than just removing the step in the docs job, let's remove it from all of them to be consistent; and we might revisit this decision in the future if/when the default versions change again (which might make CI jobs fail again). Co-authored-by: Richard Webb <richard.webb@helpsystems.com>
knocte
added a commit
to knocte/FSharpLint
that referenced
this pull request
Nov 14, 2025
Recent fix [1] for our scheduled CI build didn't last long. Suddenly the "Restore tools" step (`dotnet tool restore`) started failing in Linux because the GithubActions agent's dotnet version was apparently upgraded from 9.0.306 to 9.0.307. Given this, the most sensible approach to fix this is revisit our RollForward policy, which was disabled in a recent PR [2] because of apparent issues when upgrading our docs generation. That issue seems to not be happenning anymore because our CIs are green even when we upgraded to a .NET version newer than 9.0.300 (maybe thanks to our Fornax dependency upgrade?), so it seems safe to restore to a "Minor" setting here. [1] fsprojects#780 [2] fsprojects#736
knocte
added a commit
that referenced
this pull request
Nov 14, 2025
Recent fix [1] for our scheduled CI build didn't last long. Suddenly the "Restore tools" step (`dotnet tool restore`) started failing in Linux because the GithubActions agent's dotnet version was apparently upgraded from 9.0.306 to 9.0.307. Given this, the most sensible approach to fix this is revisit our RollForward policy, which was disabled in a recent PR [2] because of apparent issues when upgrading our docs generation. That issue seems to not be happenning anymore because our CIs are green even when we upgraded to a .NET version newer than 9.0.300 (maybe thanks to our Fornax dependency upgrade?), so it seems safe to restore to a "Minor" setting here. [1] #780 [2] #736
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated .NET9.x minor version and dropped setup-.NET steps in GitHubActions in order to fix CI build of the
docsjob.Somehow, on the same day as the .NETv10 release, our CI started failing without changing anything (thanks to our
on: schedule: cron:trigger we detected this, as it runs daily), but only in the docs job. After some discussion about Fornax in PRs 770 and 779 (given that we updated this dep in PR#767 recently), it was discovered that the default .NET version of current GitHubActions agents works out of of the box without needing to run any setup-dotnet action.So then, rather than just removing the step in the docs job, let's remove it from all of them to be consistent; and we might revisit this decision in the future if/when the default versions change again (which might make CI jobs fail again).