Skip to content

Conversation

@gusty
Copy link
Member

@gusty gusty commented Nov 26, 2023

The original code had these implementations but we didn't include them because we needed #569

@gusty gusty force-pushed the gus/matrix-vector-interfaces branch 5 times, most recently from 6997fcf to dfa12a0 Compare November 26, 2023 10:30
@gusty gusty force-pushed the gus/matrix-vector-interfaces branch 3 times, most recently from 27f86e4 to 4b38cbf Compare November 26, 2023 16:50
@gusty gusty marked this pull request as ready for review November 26, 2023 16:51
Copy link
Member

@cannorin cannorin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@gusty
Copy link
Member Author

gusty commented Nov 30, 2023

Note that I did the rebase in a separate commit intentionally in order to prove that #569 enabled this.
image

@gusty gusty merged commit cd84939 into master Nov 30, 2023
@gusty gusty deleted the gus/matrix-vector-interfaces branch February 12, 2024 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants