Skip to content

Test on Mono 4.0#330

Merged
dsyme merged 5 commits intofsprojects:masterfrom
sideeffffect:master
Jan 5, 2016
Merged

Test on Mono 4.0#330
dsyme merged 5 commits intofsprojects:masterfrom
sideeffffect:master

Conversation

@sideeffffect
Copy link
Copy Markdown
Contributor

@sideeffffect sideeffffect commented Oct 10, 2015

this also fixes the README badges

@sideeffffect sideeffffect force-pushed the master branch 4 times, most recently from ad3a3b0 to cc415dc Compare October 11, 2015 00:45
@sideeffffect sideeffffect mentioned this pull request Oct 11, 2015
Closed
@sideeffffect sideeffffect force-pushed the master branch 2 times, most recently from a73be31 to 70b38fb Compare November 15, 2015 20:20
@sideeffffect
Copy link
Copy Markdown
Contributor Author

sideeffffect commented Nov 15, 2015

This is weird. I saw that there are problems when creating packages via nuget.exe, so I migrated to Paket. After the migration to Paket (paket convert-from-nuget) the test FSharpx.Tests.MonoidTests.bytestring monoid fails like this:

   bytestring : monoid left identity-Falsifiable, after 1 test (0 shrinks) (StdGen (84118145,296082434)):
seq []
with exception:
System.NullReferenceException: Object reference not set to an instance of an object
...

@forki @mausch guys do you know what is going on with this?

@dsyme
Copy link
Copy Markdown
Contributor

dsyme commented Dec 15, 2015

The migration looks good so I think this can be merged - it's good to have this on paket. Next step is to disable the test above and fix the problem.

@dsyme
Copy link
Copy Markdown
Contributor

dsyme commented Dec 15, 2015

Can you fix the merge conflicts please?

@sideeffffect
Test on Mono 4.0
b740b7b 
this also fixes the README badges
@sideeffffect sideeffffect force-pushed the master branch 5 times, most recently from 23a9274 to 8bdeb4a Compare December 19, 2015 16:07
@sideeffffect sideeffffect force-pushed the master branch 3 times, most recently from 7e25a23 to a54f2ab Compare December 19, 2015 16:54
@sideeffffect
Copy link
Copy Markdown
Contributor Author

sideeffffect commented Dec 19, 2015

done

dsyme added a commit that referenced this pull request Jan 5, 2016
@dsyme
Merge pull request #330 from sideeffffect/master
1de5dde 
Test on Mono 4.0
@dsyme dsyme merged commit 1de5dde into fsprojects:master Jan 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sideeffffect @dsyme