Readable assertion messages on failure.

[CaptnCodr]

This fixes the assertion for Xunit and MsTest in #154 which prints on e.g.:
Ok "hello" |> should equal (Ok "world")

This result on failure:
Equals Ok "world" was Microsoft.FSharp.Core.FSharpResult`2[System.String,System.Object]

It's now printing:
Equals Ok "world" was Ok "hello"

Btw. I made some code cleanup.

[sergey-tihon]

Thank you @CaptnCodr
Can you please add xUnit and MSTests tests for the case that you fix.

[CaptnCodr]

Thank you @CaptnCodr
Can you please add xUnit and MSTests tests for the case that you fix.

Yes, I did now.

While writing the tests we may consider to have an operator that returns a full exception to check it's types and messages. You come not far with throwWithMessage. e.g. throwException.

[CaptnCodr]

In the last commit I merged the assertion syntax from Xunit to MsTest tests to have tests identical.

[sergey-tihon]

Why you replaced . in test names by ,?

[CaptnCodr]

This tests with . doesn't show up in my test explorer. Should I undo this?

[sergey-tihon]

in VS?

[sergey-tihon]

I thought it already fixed microsoft/testfx#682

[CaptnCodr]

Yes, in VS 16.6.2.

[CaptnCodr]

I discovered that tests with period in their name are shown in a separate section within the test explorer.
In the coming PR I will undo this, because they're still there. I'm not satisfied with the , or other sequences (e.g. ..) inside the test name.

[CaptnCodr]

@sergey-tihon FYI: dotnet/fsharp#9609

[sergey-tihon]

Merged and released as v3.9.0
thank you @CaptnCodr for this contribution.

[cboudereau]

Thank you guys!