Merged
Conversation
| | false -> | ||
| use sr = new System.IO.StreamReader(schemaPathRaw) | ||
| | _ -> | ||
| let request = WebRequest.Create(schemaPathRaw) |
Member
There was a problem hiding this comment.
@xperiandri why do you use WebRequest to load file content from hard drive?
Contributor
Author
There was a problem hiding this comment.
Because it is universal and can handle FTP and whatever other protocol you want and register.
File and FTP includes out of the box
|
|
||
| let readSchemaPath (headersStr:string) (schemaPathRaw:string) = | ||
| async { | ||
| match schemaPathRaw.StartsWith("http", true, null) with |
Member
There was a problem hiding this comment.
previously this condition worked like if it start with http (so this is url, http or https) then we load using HTTP request otherwise load local file from file system
Contributor
Author
There was a problem hiding this comment.
Agree, missed this point. I'll fix
xperiandri
force-pushed
the
relative-path-fix
branch
from
5aa1714 to
fc2c584
Compare
Member
|
Thank you for this fix @xperiandri ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed relative path resolution, added support for FTP scheme