Fix: CT parameter name uniqueness in CancellationToken overload generation#339
Draft
Copilot wants to merge 2 commits intorepo-assist/feat-cancellationtoken-issue-212-2026-03-23-448c1cde90ec7d95from
Draft
Conversation
…I params named 'cancellationToken' Co-authored-by: sergey-tihon <1197905+sergey-tihon@users.noreply.github.com> Agent-Logs-Url: https://github.com/fsprojects/SwaggerProvider/sessions/7d588ec7-c4df-4a6c-89f8-9c13c2472d29
Copilot
AI
changed the title
[WIP] [WIP] Address feedback on CancellationToken support for OpenApiClientProvider
Fix: CT parameter name uniqueness in CancellationToken overload generation
Mar 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If an OpenAPI spec defines a parameter named
cancellationToken, the generated overload would emit two parameters with the same name — one from the spec and one for the injectedCancellationToken.Changes
usedNamesset alongsideprovidedParametersinstead of discarding it with|> sndcancellationToken→cancellationToken1→cancellationToken2→ …, matching the existingUniqueNameGeneratorconventioninvokeCodealready extracts the CT argument by position (last inargs), so it correctly handles the CT regardless of the name chosen✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.