Replace CancellationToken overloads with a single optional parameter#340
Draft
Copilot wants to merge 3 commits intorepo-assist/feat-cancellationtoken-issue-212-2026-03-23-448c1cde90ec7d95from
Draft
Conversation
… generated methods Co-authored-by: sergey-tihon <1197905+sergey-tihon@users.noreply.github.com> Agent-Logs-Url: https://github.com/fsprojects/SwaggerProvider/sessions/4498d505-289e-4053-b797-faf89db707dd
…ken parameter Co-authored-by: sergey-tihon <1197905+sergey-tihon@users.noreply.github.com> Agent-Logs-Url: https://github.com/fsprojects/SwaggerProvider/sessions/4498d505-289e-4053-b797-faf89db707dd
Copilot
AI
changed the title
[WIP] [WIP] Address feedback on CancellationToken support in OpenApiClientProvider methods
Replace CancellationToken overloads with a single optional parameter
Mar 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The implementation generated two overloads per operation (with/without
CancellationToken) while the intended API surface was a single method with an optionalcancellationTokenparameter defaulting toCancellationToken.None.Changes
cancellationToken: CancellationTokenparameter. PassingnullasoptionalValuetoProvidedParametercorrectly encodesdefault(CancellationToken)in CLI metadata — identical to how C# encodesct = defaultfor struct parameters.compileOperation: RemovedincludeCancellationToken: boolflag; CT parameter is always appended unconditionally.invokeCode: CT is always extracted from the last argument position — no conditional branch.Callers with no CT argument continue to work unchanged; callers that want explicit cancellation pass the token directly.
⚡ Quickly spin up Copilot coding agent tasks from anywhere on your macOS or Windows machine with Raycast.