[repo-assist] perf: string concatenation fast-paths + skip UriBuilder when no query params

[github-actions]

🤖 This PR was created by Repo Assist, an automated AI assistant.

Summary

Three focused runtime performance improvements with no functional changes.

1. combineUrl — eliminate sprintf format parsing

sprintf "%s/%s" ... incurs format-string parsing and intermediate allocation on every HTTP call. Replaced with direct string concatenation:

// Before
let combineUrl urlA urlB = sprintf "%s/%s" (urlA.TrimEnd('/')) (urlB.TrimStart('/'))

// After
let combineUrl urlA urlB = urlA.TrimEnd('/') + "/" + urlB.TrimStart('/')

2. createHttpRequest — skip UriBuilder + ParseQueryString when there are no query params

For operations with no query parameters (the majority in typical APIs), the old code still allocated a UriBuilder, called System.Web.HttpUtility.ParseQueryString, and called builder.Uri.PathAndQuery. Added an early-exit on the fast path:

if List.isEmpty queryParams then
    address  // no allocation at all
else
    // existing UriBuilder path

3. formatObject — avoid String.Format boxing overhead

String.Format("{0}={1}", p.Name, s) boxes both string arguments as obj. Replaced with plain string concatenation p.Name + "=" + s, and similarly for the array and wrapper cases.

4. buildXmlDoc — single allocation via String.Concat

Chained + over four parts creates three intermediate strings. String.Concat(a, b, c, d) pre-computes the total length and allocates once.

Test Status

✅ All 414 unit tests pass (dotnet tests/SwaggerProvider.Tests/bin/Release/net10.0/SwaggerProvider.Tests.dll)
✅ Build succeeded (0 errors, warnings only from pre-existing unrelated code)
✅ Fantomas format check passes

Generated by 🌈 Repo Assist, see workflow run. Learn more.

To install this agentic workflow, run

gh aw add githubnext/agentics/workflows/repo-assist.md@94ec5db57374c5b04a4b8eef8b4413f9af44d63f

[sergey-tihon]

@copilot fix the build and formattion

[Copilot]

Pull request overview

This PR applies small runtime/design-time allocation optimizations in helper code used by generated OpenAPI clients.

Changes:

• Replaces several String.Format/sprintf calls with direct string concatenation.
• Adds an empty-query fast path in request URI creation.
• Uses String.Concat when assembling XML documentation strings.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File	Description
src/SwaggerProvider.Runtime/RuntimeHelpers.fs	Optimizes object formatting, URL combining, and request URI creation.
src/SwaggerProvider.DesignTime/Utils.fs	Optimizes XML doc string assembly.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[sergey-tihon]

@copilot address inilne comments

[Copilot]

@copilot fix the build and formattion

Fixed in commit 818375b. The String.Concat(a, b, c, d) call in buildXmlDoc was reverted back to a + b + c + d — that function runs at design-time only (not a hot path), and the 4-argument Concat can cause the F# compiler to emit a string[] array call that may have issues with netstandard2.0 targets in some environments.

All other perf improvements are kept intact (combineUrl, createHttpRequest fast-path, formatObject). Format check passes, build succeeds, 414/414 unit tests pass.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

• petstore.swagger.io
  • Triggering command: /usr/share/dotnet/dotnet /usr/share/dotnet/dotnet /usr/share/dotnet/sdk/10.0.201/FSharp/fsc.dll @/tmp/MSBuildTempaD7qNM/tmp48267ff1e2c74f9b9752e053df20de83.rsp git conf�� get --local iptables committer.email (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

• Configure Actions setup steps to set up my environment, which run before the firewall is enabled
• Add the appropriate URLs or hosts to the custom allowlist in this repository's Copilot coding agent settings (admins only)

[Copilot]

@copilot address inilne comments

Fixed in commit e92fa61.

The fast path now applies address.TrimStart('/') to match the original UriBuilder branch's PathAndQuery.TrimStart('/') normalisation. OpenAPI schema path keys like /pets are now correctly normalized to pets on both code paths, preventing a leading-slash relative URI from silently dropping the HttpClient.BaseAddress base path.

Three new tests were added to CreateHttpRequestTests covering:

• /pets with no query params → "pets"
• /pets/42 with no query params → "pets/42"
• /pets with query params → no leading slash, query params preserved

[Copilot]

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

[sergey-tihon]

@copilot fix inilne comments

[Copilot]

@copilot fix inilne comments

Fixed in commit a60dc42:

1. Signature narrowing — changed (queryParams: (string * string) list) back to seq<string * string> (matching the original inferred type) and replaced List.isEmpty with Seq.isEmpty. Callers passing arrays or sequences remain compatible.

2. PR description — updated to drop the reverted buildXmlDoc String.Concat change; the description now reflects only the three changes that are actually in the diff.