Minor adjustments to Spacemacs layer and docs #37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove flycheck-mode from fsharp2 package list. auto-complete initializes it for us, and fsharp2 doesn't do any setup of its own. - The LSP layer binds keys on its own now, so Spacemacs removed the spacemacs/lsp-bind-keys-for-mode function. Trying to call it results in an error when the layer initializes. - Add notes to documentation about suppressing lsp-mode warnings, which happen because lsp-mode can't process fsharp/*progress notifications
|
I'm not really familiar with spacemacs, but this looks reasonable. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove flycheck-mode from fsharp2 package list. auto-complete
initializes it for us, and fsharp2 doesn't need to do its own setup.
The LSP layer binds keys on its own now, so Spacemacs removed the
spacemacs/lsp-bind-keys-for-mode function. Trying to call it results
in an error when the layer initializes.
Add notes to documentation about suppressing lsp-mode warnings, which
happen because lsp-mode can't process fsharp/*progress notifications