Skip to content

Add class attribute protocol to HTTPFileSystem #1935

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 28, 2025
+13 −0
Merged

Add class attribute protocol to HTTPFileSystem #1935

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
49d78a4
tests: add a test to ensure the http fs protocol is 'http'
ap-- Oct 25, 2025
b056eeb
tests: add a test to ensure the http fs protocol is 'http'
ap-- Oct 25, 2025
e54ae8a
fsspec.implementations.http: add protocol tuple to http filesystem
ap-- Oct 25, 2025
dd46697
simplify test
martindurant Oct 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions fsspec/implementations/http.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@ class HTTPFileSystem(AsyncFileSystem):
HTML href tags will be used.
"""

protocol = ("http", "https")
sep = "/"

def __init__(
Expand Down
12 changes: 12 additions & 0 deletions fsspec/implementations/tests/test_http.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -630,3 +630,15 @@ def test_pipe_file(server, tmpdir, reset_files):
bytesio = io.BytesIO(b"BytesIO content")
fs.pipe_file(server.address + "/piped_bytes", bytesio.getvalue())
assert fs.cat(server.address + "/piped_bytes") == b"BytesIO content"


@pytest.mark.parametrize("protocol", ["http", "https"])
def test_protocol_independent_of_first_used_protocol(protocol):
from fsspec import filesystem

filesystem(protocol)
fs0 = filesystem("http")
p0 = fs0.protocol[0] if isinstance(fs0.protocol, tuple) else fs0.protocol
fs1 = filesystem("https")
p1 = fs1.protocol[0] if isinstance(fs1.protocol, tuple) else fs1.protocol
assert p0 == p1 == "http"
Loading