Implement created and modified methods from abstract filesystem class… #1971
+103
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
This looks fine - can you please add a test to test_webhdfs.py which calls them? |
Contributor
Author
|
Uh, of course. Lookit at it fast I thought there was no tests specifically for webhdfs. I'll add them in a few. |
Contributor
Author
|
Done, please, take a look. |
|
Thanks for the PR. We also faced the same issue on using duckdb with WebHDFS and had to patch the modified function. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… for webhdfs.
I noticed webhdfs do not have implementations for created and modified, and fail in some usages, as when used by duckdb to read parquet files (for example) from HDFS.
As WebHDFS schema seems not to offer creation time, I used modificationTime parameter on the info answer from HDFS.