DEP: de-duplicate and sort optional dependencies#2021
Merged
martindurant merged 1 commit intofsspec:masterfrom Apr 29, 2026
Merged
DEP: de-duplicate and sort optional dependencies#2021martindurant merged 1 commit intofsspec:masterfrom
martindurant merged 1 commit intofsspec:masterfrom
Conversation
neutrinoceros
force-pushed
the
dep/dedupe
branch
from
9f58765 to
3abfa3b
Compare
martindurant
added a commit
that referenced
this pull request
Apr 29, 2026
martindurant
added a commit
that referenced
this pull request
Apr 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed a lot of duplication in optional-dependencies specifications. These can be removed using recursive optional dependencies, which pip has been supporting since version 21.2 (released ~5 years ago).
I also note that there are a couple extras (
dev,doc,testandtest_all) used to define what seem like dev-only requirements. I would propose to move these to PEP 735 dependency groups, which have the benefit of not being user-visible, as is probably intented, though it only became a standard in 2024 so there's a clear historical reason why they weren't done that way from the get go.