Support independent chunk and block sizes for both Read and Write FixedDuration microbenchmarks#779
Merged
ankitaluthra1 merged 2 commits intofsspec:mainfrom Mar 31, 2026
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #779 +/- ##
==========================================
+ Coverage 75.84% 76.18% +0.34%
==========================================
Files 14 14
Lines 2645 2645
==========================================
+ Hits 2006 2015 +9
+ Misses 639 630 -9 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
yuxin00j
force-pushed
the
read-benchmark
branch
from
cb3dc98 to
da7f7bf
Compare
Collaborator
|
/gcbrun |
yuxin00j
force-pushed
the
read-benchmark
branch
from
da7f7bf to
9187344
Compare
jasha26
reviewed
Mar 25, 2026
…map parameters. - Rename block_sizes_mb to chunk_sizes_mb in configs.yaml. - Update configs.py to support chunk_sizes_mb and block_sizes_mb independently. - Update test_configs.py to match refined logic.
… test race conditions
yuxin00j
force-pushed
the
read-benchmark
branch
from
5340403 to
b194de5
Compare
yuxin00j
changed the title
jasha26
approved these changes
Mar 27, 2026
Collaborator
|
/gcbrun |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
chunk_sizes_mbandblock_sizes_mbindependently inReadFixedDurationConfigurator.block_sizes_mbtochunk_sizes_mbinread_fixed_duration/configs.yaml.block_sizes_mbinWriteFixedDurationConfiguratorandWriteFixedDurationBenchmarkParameters.block_sizetogcs_kwargsintest_write_multi_processto enable testing various block sizes for writes.test_configs.pyto match the refined logic for both read and write configurators.Benchmark run result