Skip to content

asyncssh: fix api change: make kwargs to posargs #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 17, 2022
Merged

asyncssh: fix api change: make kwargs to posargs #18

merged 1 commit into from
Mar 17, 2022

Conversation

@skshetry
Copy link
Collaborator

@skshetry skshetry commented Mar 17, 2022 •
edited
Loading

In asyncssh==2.9, the API in SSHClientConfig.load was changed from accepting kwargs to only positional args and requires arguments to be passed in order of:

last_config, config_paths, reload, local_user, user, host, port

This should support all asyncssh versions supported including 2.9.

@skshetry
asyncssh: fix api change: make kwargs to posargs
d6b263d 
The API in `SSHClientConfig.load` was changed from accepting `kwargs`
to only positional args.
@skshetry skshetry mentioned this pull request Mar 17, 2022
Closed
@pmrowla pmrowla merged commit 6a71778 into fsspec:master Mar 17, 2022
@skshetry skshetry deleted the fix-config-api-change branch March 17, 2022 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pmrowla pmrowla pmrowla approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@skshetry @pmrowla